-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update typescript version to 5 #7272
Open
Muhammad-Altabba
wants to merge
11
commits into
4.x
Choose a base branch
from
7144-fix-typescript-version-issue
base: 4.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
013847a
fix some issues detected by typescript v5
Muhammad-Altabba 1c9f150
upgrade typescript to v5
Muhammad-Altabba ade7ab6
Merge branch '4.x' into 7144-fix-typescript-version-issue
Muhammad-Altabba 6d4c4ba
fix a type casting
Muhammad-Altabba 5ad813a
Merge branch '4.x' into 7144-fix-typescript-version-issue
Muhammad-Altabba 2b13128
Merge branch '4.x' into 7144-fix-typescript-version-issue
Muhammad-Altabba 35ad780
decrease the minor version of typescript
Muhammad-Altabba c616709
Merge branch '4.x' into 7144-fix-typescript-version-issue
Muhammad-Altabba 04da324
temp change the canary release to be published on feature branch
Muhammad-Altabba 32c8cc8
Merge branch '4.x' into 7144-fix-typescript-version-issue
Muhammad-Altabba 8c17262
revert a temp change
Muhammad-Altabba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/formatters.ts","./src/index.ts","./src/types.ts","./src/utils.ts","./src/web3_batch_request.ts","./src/web3_config.ts","./src/web3_context.ts","./src/web3_event_emitter.ts","./src/web3_promi_event.ts","./src/web3_request_manager.ts","./src/web3_subscription_manager.ts","./src/web3_subscriptions.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/error_codes.ts","./src/index.ts","./src/web3_error_base.ts","./src/errors/account_errors.ts","./src/errors/connection_errors.ts","./src/errors/contract_errors.ts","./src/errors/core_errors.ts","./src/errors/ens_errors.ts","./src/errors/generic_errors.ts","./src/errors/provider_errors.ts","./src/errors/response_errors.ts","./src/errors/rpc_error_messages.ts","./src/errors/rpc_errors.ts","./src/errors/schema_errors.ts","./src/errors/signature_errors.ts","./src/errors/transaction_errors.ts","./src/errors/utils_errors.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/decode_contract_error_data.ts","./src/eip_712.ts","./src/index.ts","./src/utils.ts","./src/api/errors_api.ts","./src/api/events_api.ts","./src/api/functions_api.ts","./src/api/logs_api.ts","./src/api/parameters_api.ts","./src/coders/decode.ts","./src/coders/encode.ts","./src/coders/types.ts","./src/coders/utils.ts","./src/coders/base/address.ts","./src/coders/base/array.ts","./src/coders/base/bool.ts","./src/coders/base/bytes.ts","./src/coders/base/index.ts","./src/coders/base/number.ts","./src/coders/base/numbersLimits.ts","./src/coders/base/string.ts","./src/coders/base/tuple.ts","./src/coders/base/utils.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/account.ts","./src/index.ts","./src/schemas.ts","./src/types.ts","./src/wallet.ts","./src/common/common.ts","./src/common/enums.ts","./src/common/index.ts","./src/common/types.ts","./src/common/utils.ts","./src/common/chains/goerli.ts","./src/common/chains/mainnet.ts","./src/common/chains/sepolia.ts","./src/common/eips/1153.ts","./src/common/eips/1559.ts","./src/common/eips/2315.ts","./src/common/eips/2537.ts","./src/common/eips/2565.ts","./src/common/eips/2718.ts","./src/common/eips/2929.ts","./src/common/eips/2930.ts","./src/common/eips/3074.ts","./src/common/eips/3198.ts","./src/common/eips/3529.ts","./src/common/eips/3540.ts","./src/common/eips/3541.ts","./src/common/eips/3554.ts","./src/common/eips/3607.ts","./src/common/eips/3651.ts","./src/common/eips/3670.ts","./src/common/eips/3675.ts","./src/common/eips/3855.ts","./src/common/eips/3860.ts","./src/common/eips/4345.ts","./src/common/eips/4399.ts","./src/common/eips/4844.ts","./src/common/eips/4895.ts","./src/common/eips/5133.ts","./src/common/eips/index.ts","./src/common/hardforks/arrowGlacier.ts","./src/common/hardforks/berlin.ts","./src/common/hardforks/byzantium.ts","./src/common/hardforks/chainstart.ts","./src/common/hardforks/constantinople.ts","./src/common/hardforks/dao.ts","./src/common/hardforks/grayGlacier.ts","./src/common/hardforks/homestead.ts","./src/common/hardforks/index.ts","./src/common/hardforks/istanbul.ts","./src/common/hardforks/london.ts","./src/common/hardforks/merge.ts","./src/common/hardforks/mergeForkIdTransition.ts","./src/common/hardforks/muirGlacier.ts","./src/common/hardforks/petersburg.ts","./src/common/hardforks/shanghai.ts","./src/common/hardforks/sharding.ts","./src/common/hardforks/spuriousDragon.ts","./src/common/hardforks/tangerineWhistle.ts","./src/tx/address.ts","./src/tx/baseTransaction.ts","./src/tx/constants.ts","./src/tx/eip1559Transaction.ts","./src/tx/eip2930Transaction.ts","./src/tx/index.ts","./src/tx/legacyTransaction.ts","./src/tx/transactionFactory.ts","./src/tx/types.ts","./src/tx/utils.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/constant.ts","./src/contract-deployer-method-class.ts","./src/contract.ts","./src/encoding.ts","./src/index.ts","./src/log_subscription.ts","./src/types.ts","./src/utils.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/config.ts","./src/ens.ts","./src/index.ts","./src/registry.ts","./src/resolver.ts","./src/utils.ts","./src/abi/ens/ENSRegistry.ts","./src/abi/ens/PublicResolver.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/iban.ts","./src/index.ts","./src/types.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/index.ts","./src/personal.ts","./src/rpc_method_wrappers.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/constants.ts","./src/index.ts","./src/rpc_method_wrappers.ts","./src/schemas.ts","./src/types.ts","./src/validation.ts","./src/web3_eth.ts","./src/web3_subscriptions.ts","./src/utils/decode_signed_transaction.ts","./src/utils/decoding.ts","./src/utils/detect_transaction_type.ts","./src/utils/format_transaction.ts","./src/utils/get_revert_reason.ts","./src/utils/get_transaction_error.ts","./src/utils/get_transaction_gas_pricing.ts","./src/utils/index.ts","./src/utils/prepare_transaction_for_signing.ts","./src/utils/reject_if_block_timeout.ts","./src/utils/send_tx_helper.ts","./src/utils/transaction_builder.ts","./src/utils/try_send_transaction.ts","./src/utils/wait_for_transaction_receipt.ts","./src/utils/watch_transaction_by_polling.ts","./src/utils/watch_transaction_by_subscription.ts","./src/utils/watch_transaction_for_confirmations.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/index.ts","./src/net.ts","./src/rpc_method_wrappers.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/index.ts","./src/types.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/index.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/index.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/errors.ts","./src/eth_rpc_methods.ts","./src/index.ts","./src/net_rpc_methods.ts","./src/personal_rpc_methods.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/errors.ts","./src/index.ts","./src/types.ts","./src/web3_provider.ts","./src/web3_provider_quicknode.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/data_format_types.ts","./src/error_types.ts","./src/eth_abi_types.ts","./src/eth_contract_types.ts","./src/eth_types.ts","./src/index.ts","./src/json_rpc_types.ts","./src/primitives_types.ts","./src/utility_types.ts","./src/web3_api_types.ts","./src/web3_base_provider.ts","./src/web3_base_wallet.ts","./src/web3_deferred_promise_type.ts","./src/apis/eth_execution_api.ts","./src/apis/eth_personal_api.ts","./src/apis/web3_eth_execution_api.ts","./src/apis/web3_net_api.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/chunk_response_parser.ts","./src/converters.ts","./src/event_emitter.ts","./src/formatter.ts","./src/hash.ts","./src/index.ts","./src/json_rpc.ts","./src/objects.ts","./src/promise_helpers.ts","./src/random.ts","./src/socket_provider.ts","./src/string_manipulation.ts","./src/uint8array.ts","./src/uuid.ts","./src/validation.ts","./src/web3_deferred_promise.ts","./src/web3_eip1193_provider.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{"root":["./src/constants.ts","./src/default_validator.ts","./src/errors.ts","./src/formats.ts","./src/index.ts","./src/types.ts","./src/utils.ts","./src/validator.ts","./src/web3_validator.ts","./src/validation/abi.ts","./src/validation/address.ts","./src/validation/block.ts","./src/validation/bloom.ts","./src/validation/boolean.ts","./src/validation/bytes.ts","./src/validation/eth.ts","./src/validation/filter.ts","./src/validation/index.ts","./src/validation/numbers.ts","./src/validation/object.ts","./src/validation/string.ts","./src/validation/topic.ts"],"version":"5.6.2"} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will any of breaking changes in TS will affect users:
https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes
https://devblogs.microsoft.com/typescript/announcing-typescript-5-0/#breaking-changes-and-deprecations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we are updating at devDependencies, there should be no issues with the braking changes except with our code that I needed to update at few places for the detected issues.
But for the users of our lib there should be, theoretically no issues at all. However, there could be some very edge case that I am not aware of. But according to my search and up to my knowledge, there should be no issues for the users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
types created as output of build using TS in this PR are fully backward compatible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to my reading, the generated JavaScript is only affected by the targeted ECMA Script. And for the same ECMA Script, the transpiled code is compatible. I checked few of the generated JavaScript source code and things seems almost identical and 100% compatible.