-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: consistently use navigables for integration with WebDriver BiDi #10909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/fix-navigables
branch
from
January 13, 2025 12:14
23c79b6
to
77292f8
Compare
OrKoN
changed the title
Consistently use navigables for integration with WebDriver BiDi
Editorial: consistently use navigables for integration with WebDriver BiDi
Jan 13, 2025
OrKoN
force-pushed
the
orkon/fix-navigables
branch
from
January 13, 2025 12:17
77292f8
to
d500843
Compare
@domenic could you please take a look when you have a chance? ˜It looks like a preview is not being generated for this PR but I could not figure out why.˜ (looks like it worked after another push) |
OrKoN
commented
Jan 14, 2025
domenic
reviewed
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanups!
Thanks for reviewing, updated the PR! |
domenic
approved these changes
Jan 15, 2025
domenic
added
topic: navigation
integration
Better coordination across standards needed
labels
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w3c/webdriver-bidi#729 changed the WebDriver BiDi spec to use navigables instead of browsing contexts as intended. This PR fixes the WebDriver BiDi invocations that still pass browsing contexts.
(See WHATWG Working Mode: Changes for more details.)
/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )