Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: consistently use navigables for integration with WebDriver BiDi #10909

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Jan 13, 2025

w3c/webdriver-bidi#729 changed the WebDriver BiDi spec to use navigables instead of browsing contexts as intended. This PR fixes the WebDriver BiDi invocations that still pass browsing contexts.

  • At least two implementers are interested (and none opposed):
    • N/A
    • N/A
  • Tests are written and can be reviewed and commented upon at:
    • N/A
  • Implementation bugs are filed:
    • Chromium: N/A
    • Gecko: N/A
    • WebKit: N/A
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): N/A
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): N/A
  • Corresponding HTML AAM & ARIA in HTML issues & PRs: N/A
  • MDN issue is filed: N/A
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/browsing-the-web.html ( diff )
/document-lifecycle.html ( diff )

@OrKoN OrKoN force-pushed the orkon/fix-navigables branch from 23c79b6 to 77292f8 Compare January 13, 2025 12:14
@OrKoN OrKoN changed the title Consistently use navigables for integration with WebDriver BiDi Editorial: consistently use navigables for integration with WebDriver BiDi Jan 13, 2025
@OrKoN OrKoN force-pushed the orkon/fix-navigables branch from 77292f8 to d500843 Compare January 13, 2025 12:17
@OrKoN OrKoN marked this pull request as ready for review January 13, 2025 12:19
@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 14, 2025

@domenic could you please take a look when you have a chance? ˜It looks like a preview is not being generated for this PR but I could not figure out why.˜ (looks like it worked after another push)

source Show resolved Hide resolved
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups!

source Show resolved Hide resolved
source Outdated Show resolved Hide resolved
source Show resolved Hide resolved
@OrKoN OrKoN requested a review from domenic January 15, 2025 08:14
@OrKoN
Copy link
Contributor Author

OrKoN commented Jan 15, 2025

Thanks for reviewing, updated the PR!

@domenic domenic merged commit b423343 into whatwg:main Jan 15, 2025
2 checks passed
@domenic domenic added topic: navigation integration Better coordination across standards needed labels Jan 15, 2025
@OrKoN OrKoN deleted the orkon/fix-navigables branch January 15, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Better coordination across standards needed topic: navigation
Development

Successfully merging this pull request may close these issues.

2 participants