Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: consistently use navigables for integration with WebDriver BiDi #10909

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Editorial: consistently use navigables for integration with WebDriver BiDi #10909

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d500843
Consistently use navigables for integration with WebDriver BiDi
OrKoN Jan 13, 2025
c7986c2
add missing and
OrKoN Jan 14, 2025
f170077
make commas consistent
OrKoN Jan 14, 2025
a65618b
fix unused vars and undefined navigable
OrKoN Jan 15, 2025
b9d2375
Run specfmt
domenic Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 26 additions & 33 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100154,8 +100154,8 @@ location.href = '#foo';</code></pre>

<li><p>If <var>navigable</var>'s <span data-x="nav-document">active document</span>'s
<span>unload counter</span> is greater than 0, then invoke <span>WebDriver BiDi navigation
failed</span> with a <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
failed</span> with <var>navigable</var> and a <span>WebDriver BiDi navigation status</span> whose
OrKoN marked this conversation as resolved.
Show resolved Hide resolved
<span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>, and return.</p></li>
Expand Down Expand Up @@ -100228,16 +100228,12 @@ location.href = '#foo';</code></pre>
<var>navigable</var>'s <span>is delaying <code data-x="event-load">load</code> events</span> to
true.</p></li>

<li><p>Let <var>targetBrowsingContext</var> be <var>navigable</var>'s <span
data-x="nav-bc">active browsing context</span>.</p></li>

<li><p>Let <var>targetSnapshotParams</var> be the result of <span>snapshotting target snapshot
params</span> given <var>navigable</var>.</p></li>

<li><p>Invoke <span>WebDriver BiDi navigation started</span> with
<var>targetBrowsingContext</var>, and a new <span>WebDriver BiDi navigation status</span> whose
<span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
<li><p>Invoke <span>WebDriver BiDi navigation started</span> with <var>navigable</var> and a new
<span>WebDriver BiDi navigation status</span> whose <span data-x="navigation-status-id">id</span>
is <var>navigationId</var>, <span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-pending">pending</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>.</p></li>
OrKoN marked this conversation as resolved.
Show resolved Hide resolved

Expand All @@ -100246,9 +100242,9 @@ location.href = '#foo';</code></pre>
data-x="">traversal</code>", then:</p>

<ol>
<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with
<var>targetBrowsingContext</var> and a new <span>WebDriver BiDi navigation status</span> whose
<span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with <var>navigable</var> and a new
<span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>.</p></li>
Expand Down Expand Up @@ -100351,9 +100347,9 @@ location.href = '#foo';</code></pre>
navigation</span> is no longer <var>navigationId</var>, then:</p>

<ol>
<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with
<var>targetBrowsingContext</var> and a new <span>WebDriver BiDi navigation status</span>
whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with <var>navigable</var> and a
new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>url</var>.</p></li>
Expand Down Expand Up @@ -101049,10 +101045,10 @@ location.href = '#foo';</code></pre>
<var>navigable</var>, <var>historyEntry</var>, <var>entryToReplace</var>,
<var>historyHandling</var>, and <var>userInvolvement</var>.</p></li>

<li><p>Invoke <span>WebDriver BiDi fragment navigated</span> with <var>navigable</var>'s <span
data-x="nav-bc">active browsing context</span> and a new <span>WebDriver BiDi navigation
status</span> whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>,
<span data-x="navigation-status-url">url</span> is <var>url</var>, and <span
<li><p>Invoke <span>WebDriver BiDi fragment navigated</span> with <var>navigable</var> and a
new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-url">url</span> is <var>url</var>, and <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>".</p></li>
</ol>
Expand Down Expand Up @@ -101860,9 +101856,6 @@ location.href = '#foo';</code></pre>
<var>navigationParams</var>'s <span data-x="navigation-params-response">response</span> is
non-null.</p></li>

<li><p>Let <var>currentBrowsingContext</var> be <var>navigable</var>'s <span
data-x="nav-bc">active browsing context</span>.</p></li>

<li><p>Let <var>documentResource</var> be <var>entry</var>'s <span
data-x="she-document-state">document state</span>'s <span
data-x="document-state-resource">resource</span>.</p></li>
Expand Down Expand Up @@ -102037,9 +102030,9 @@ location.href = '#foo';</code></pre>
steps</span> for <var>navigationParams</var>'s <span
data-x="navigation-params-reserved-environment">reserved environment</span>.</p></li>

<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with
<var>currentBrowsingContext</var> and a new <span>WebDriver BiDi navigation status</span>
whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
<li><p>Invoke <span>WebDriver BiDi navigation failed</span> with <var>navigable</var> and a
new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled">canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>navigationParams</var>'s <span
Expand Down Expand Up @@ -102077,9 +102070,9 @@ location.href = '#foo';</code></pre>
<li><p>Handle <var>navigationParams</var>'s <span
data-x="navigation-params-response">response</span> <span>as a download</span>.</p></li>

<li><p>Invoke <span>WebDriver BiDi download started</span> with
<var>currentBrowsingContext</var> and a new <span>WebDriver BiDi navigation status</span>
whose <span data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
<li><p>Invoke <span>WebDriver BiDi download started</span> with <var>navigable</var> and a
new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>navigationId</var>, <span
data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-complete">complete</code>", and <span
data-x="navigation-status-url">url</span> is <var>navigationParams</var>'s <span
Expand Down Expand Up @@ -106046,11 +106039,11 @@ new PaymentRequest(&hellip;); // Allowed to use
navigation ID for WebDriver BiDi</span> is non-null, then:</p>

<ol>
<li><p>Invoke <span>WebDriver BiDi navigation aborted</span> with <var>document</var>'s <span
data-x="concept-document-bc">browsing context</span>, and a new <span>WebDriver BiDi navigation
status</span> whose <span data-x="navigation-status-id">id</span> is
<var>document</var>'s <span data-x="concept-document-navigation-id">during-loading navigation
ID for WebDriver BiDi</span>, <span data-x="navigation-status-status">status</span> is "<code
<li><p>Invoke <span>WebDriver BiDi navigation aborted</span> with <var>document</var>'s
<span>node navigable</span> and a new <span>WebDriver BiDi navigation status</span> whose <span
data-x="navigation-status-id">id</span> is <var>document</var>'s <span
data-x="concept-document-navigation-id">during-loading navigation ID for WebDriver BiDi</span>,
<span data-x="navigation-status-status">status</span> is "<code
data-x="navigation-status-canceled" >canceled</code>", and <span
data-x="navigation-status-url">url</span> is <var>document</var>'s <span
data-x="concept-document-url">URL</span>.</p></li>
OrKoN marked this conversation as resolved.
Show resolved Hide resolved
Expand Down