-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.4.0: Markdown Remote Images #11021
base: main
Are you sure you want to change the base?
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this helpful feature and corresponding documentation, @p0lyw0lf ! I think given what you've added, we could probably update some of our existing wording vs. tacking on another section so it feels more "worked in" with everything else.
See what you think!
Co-authored-by: Sarah Rainsberger <[email protected]>
Thanks for the review @sarah11918! I've implemented your suggestions. As you guessed, I was trying to follow the directions & be very careful to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, @p0lyw0lf ! I'm sure people will love this feature, and we're happy you contributed it. Welcome to Team Docs! 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work! 🙌
Description
As part of the changes in withastro/astro#13254, I've added some documentation describing the updates.
Related issues & labels
For Astro version:
5.4
. See astro PR #13254.First-time contributor to Astro Docs?
Discord username: polywolf