Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Update Aztec editor to 2.1.3. #20771

Merged
merged 1 commit into from
May 7, 2024
Merged

[Bug] Update Aztec editor to 2.1.3. #20771

merged 1 commit into from
May 7, 2024

Conversation

notandyvee
Copy link
Contributor

Fixes: #20738


To Test:

  • Create a post with text and add color to one word.
  • Edit the post.
  • If you don't experience a crash, we are good.

Regression Notes

  1. Potential unintended areas of impact

    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Unit tests

  3. What automated tests I added (or what prevented me from doing so)

    n/a


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@notandyvee notandyvee added this to the 24.9 milestone May 6, 2024
@notandyvee notandyvee requested review from antonis and thomashorta May 6, 2024 20:03
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 \--- project :libs:editor
-     +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
+     +--- org.wordpress:aztec:{strictly v2.1.3} -> v2.1.3
-     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.2 (*)
-     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.3} -> v2.1.3
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.3 (*)
+     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
-     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.2 (*)
-     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.3} -> v2.1.3
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.3 (*)
+     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
      \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.118.0
           \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.118.0
-               +--- org.wordpress:aztec:v2.1.2 (*)
+               +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
-               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 (*)
+               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
-               +--- org.wordpress.aztec:wordpress-comments:v2.1.2 (*)
+               +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
                \--- org.wordpress.aztec:glide-loader:v2.1.2
-                    \--- org.wordpress:aztec:v2.1.2 (*)
+                    \--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20771-969f274
Commit969f274
Direct Downloadjetpack-prototype-build-pr20771-969f274.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20771-969f274
Commit969f274
Direct Downloadwordpress-prototype-build-pr20771-969f274.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.53%. Comparing base (6c79ab1) to head (969f274).

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #20771      +/-   ##
==========================================
- Coverage   40.69%   40.53%   -0.16%     
==========================================
  Files        1491     1485       -6     
  Lines       68675    68497     -178     
  Branches    11356    11348       -8     
==========================================
- Hits        27944    27766     -178     
  Misses      38193    38193              
  Partials     2538     2538              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thomashorta thomashorta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to reproduce the issue but the code for the fix makes total sense and should fix the crash completely, so it looks good to me! Thanks for the fix!

@ravishanker ravishanker merged commit d7de297 into trunk May 7, 2024
20 of 23 checks passed
@ravishanker ravishanker deleted the andy/issue-20738 branch May 7, 2024 06:07
@antonis
Copy link
Contributor

antonis commented May 7, 2024

Hey @notandyvee, @thomashorta 👋
Thanks again for covering for me and fixing the regression I introduced 🙇
Considering the impact of the crash I was wondering if it would makes sense to ship the fix earlier with 24.8. Wdyt?

@antonis antonis mentioned this pull request May 8, 2024
13 tasks
@antonis
Copy link
Contributor

antonis commented May 8, 2024

Considering the impact of the crash I was wondering if it would makes sense to ship the fix earlier with 24.8. Wdyt?

I've opened a PR for this #20782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StringIndexOutOfBoundsException: length=0; index=0
5 participants