-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Update Aztec editor to 2.1.3. #20771
Conversation
Quality Gate passedIssues Measures |
Found 1 violations: The PR caused some dependency changes (expand to see details)
\--- project :libs:editor
- +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
+ +--- org.wordpress:aztec:{strictly v2.1.3} -> v2.1.3
- +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.2 (*)
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.3} -> v2.1.3
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.3 (*)
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.2 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.3} -> v2.1.3
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.3 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
\--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.118.0
\--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.118.0
- +--- org.wordpress:aztec:v2.1.2 (*)
+ +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
- +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
- +--- org.wordpress.aztec:wordpress-comments:v2.1.2 (*)
+ +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
\--- org.wordpress.aztec:glide-loader:v2.1.2
- \--- org.wordpress:aztec:v2.1.2 (*)
+ \--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20771 +/- ##
==========================================
- Coverage 40.69% 40.53% -0.16%
==========================================
Files 1491 1485 -6
Lines 68675 68497 -178
Branches 11356 11348 -8
==========================================
- Hits 27944 27766 -178
Misses 38193 38193
Partials 2538 2538 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to reproduce the issue but the code for the fix makes total sense and should fix the crash completely, so it looks good to me! Thanks for the fix!
Hey @notandyvee, @thomashorta 👋 |
I've opened a PR for this #20782 |
Fixes: #20738
To Test:
Regression Notes
Potential unintended areas of impact
n/a
What I did to test those areas of impact (or what existing automated tests I relied on)
Unit tests
What automated tests I added (or what prevented me from doing so)
n/a
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.