-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Aztec Editor to 2.1.3 #20782
Conversation
Quality Gate passedIssues Measures |
Found 1 violations: The PR caused some dependency changes (expand to see details)
\--- project :libs:editor
- +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
+ +--- org.wordpress:aztec:{strictly v2.1.3} -> v2.1.3
- +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.2 (*)
- | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.3} -> v2.1.3
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.3 (*)
+ | \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
- +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
- | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
- | +--- org.wordpress:aztec:v2.1.2 (*)
- | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
- | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+ +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.3} -> v2.1.3
+ | +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+ | +--- org.wordpress:aztec:v2.1.3 (*)
+ | +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+ | \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
\--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.118.0
\--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.118.0
- +--- org.wordpress:aztec:v2.1.2 (*)
+ +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
- +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 (*)
+ +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
- +--- org.wordpress.aztec:wordpress-comments:v2.1.2 (*)
+ +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
\--- org.wordpress.aztec:glide-loader:v2.1.2
- \--- org.wordpress:aztec:v2.1.2 (*)
+ \--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
Please review and act accordingly
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late reply. And thank you for taking this one. LGTM.
Thanks for pushing the fix to 24.8 @antonis, this currently became our top crash on Android, so it's good to know it's getting fixed soon! 🙇🏼 |
This is a follow up to #20771 bringing the fix from wordpress-mobile/AztecEditor-Android#1080 in
24.8
release.Considering that this is the only change in Aztec 2.1.3 the update should be safe.
To Test:
See #20771
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):