Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Aztec Editor to 2.1.3 #20782

Merged
merged 1 commit into from
May 8, 2024
Merged

Updates Aztec Editor to 2.1.3 #20782

merged 1 commit into from
May 8, 2024

Conversation

antonis
Copy link
Contributor

@antonis antonis commented May 8, 2024

This is a follow up to #20771 bringing the fix from wordpress-mobile/AztecEditor-Android#1080 in 24.8 release.

Considering that this is the only change in Aztec 2.1.3 the update should be safe.


To Test:

See #20771


Regression Notes

  1. Potential unintended areas of impact

    • N/A
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@dangermattic
Copy link
Collaborator

dangermattic commented May 8, 2024

1 Warning
⚠️ This PR is assigned to the milestone 24.8 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@antonis antonis mentioned this pull request May 8, 2024
3 tasks
Copy link

sonarqubecloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@antonis antonis requested review from notandyvee and geriux May 8, 2024 15:27
@antonis antonis marked this pull request as ready for review May 8, 2024 15:28
@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused some dependency changes (expand to see details)

 \--- project :libs:editor
-     +--- org.wordpress:aztec:{strictly v2.1.2} -> v2.1.2
+     +--- org.wordpress:aztec:{strictly v2.1.3} -> v2.1.3
-     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.2} -> v2.1.2
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.2 (*)
-     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
+     +--- org.wordpress.aztec:wordpress-shortcodes:{strictly v2.1.3} -> v2.1.3
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.3 (*)
+     |    \--- androidx.appcompat:appcompat:1.0.0 -> 1.6.1 (*)
-     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.2} -> v2.1.2
-     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
-     |    +--- org.wordpress:aztec:v2.1.2 (*)
-     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
+     +--- org.wordpress.aztec:wordpress-comments:{strictly v2.1.3} -> v2.1.3
+     |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.9.10 (*)
+     |    +--- org.wordpress:aztec:v2.1.3 (*)
+     |    +--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+     |    \--- com.google.android.material:material:1.0.0 -> 1.9.0 (*)
      \--- org.wordpress.gutenberg-mobile:react-native-gutenberg-bridge:v1.118.0
           \--- org.wordpress.gutenberg-mobile:react-native-aztec:v1.118.0
-               +--- org.wordpress:aztec:v2.1.2 (*)
+               +--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)
-               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 (*)
+               +--- org.wordpress.aztec:wordpress-shortcodes:v2.1.2 -> v2.1.3 (*)
-               +--- org.wordpress.aztec:wordpress-comments:v2.1.2 (*)
+               +--- org.wordpress.aztec:wordpress-comments:v2.1.2 -> v2.1.3 (*)
                \--- org.wordpress.aztec:glide-loader:v2.1.2
-                    \--- org.wordpress:aztec:v2.1.2 (*)
+                    \--- org.wordpress:aztec:v2.1.2 -> v2.1.3 (*)

Please review and act accordingly

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20782-b1b8c2b
Commitb1b8c2b
Direct Downloadjetpack-prototype-build-pr20782-b1b8c2b.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20782-b1b8c2b
Commitb1b8c2b
Direct Downloadwordpress-prototype-build-pr20782-b1b8c2b.apk
Note: Google Login is not supported on these builds.

Copy link
Contributor

@notandyvee notandyvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late reply. And thank you for taking this one. LGTM.

@notandyvee notandyvee merged commit 7fc615f into release/24.8 May 8, 2024
27 checks passed
@notandyvee notandyvee deleted the fix/aztec-2.1.3 branch May 8, 2024 21:36
@thomashorta
Copy link
Contributor

Thanks for pushing the fix to 24.8 @antonis, this currently became our top crash on Android, so it's good to know it's getting fixed soon! 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants