Skip to content

Commit

Permalink
fix: Avoid unexpectedly marking post content as unsaved (#23969)
Browse files Browse the repository at this point in the history
* fix: Avoid unexpectedly marking post content as unsaved

The custom `editorHasChanges` implementation resulted in an
always-"dirty" state, even after saving changes via the "Update" or
"Save draft" buttons. This removal, results in the editor relying upon
the existing `editorHasChanges` implementation, which appears to be more
accurate.

https://github.com/wordpress-mobile/WordPress-iOS/blob/388dbb167b7ae6fd763ed4c90076dc94679a9dc6/WordPress/Classes/ViewRelated/Post/PostEditor.swift#L81-L83

* docs: Add release note

* docs: Fix release notes errors originating from rebasing
  • Loading branch information
dcalhoun authored Jan 14, 2025
1 parent d820f57 commit ca4794e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 2 additions & 0 deletions RELEASE-NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@
* [*] Fix an issue with fullscreen button in reply view clipped by the notch [#23965]
* [*] Remove "Lazy Images" option that is no longer part of the Jetpack plugin [#23966]
* [*] Fix an issue with "Speed up your site" section not refreshing (fails silently) [#23966]
* [**] Enable history navigation (undo and redo) for the experimental editor. [#23961]
* [*] Avoid unexpectedly marking post content as unsaved. [#23969]

25.6
-----
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,18 +70,6 @@ class NewGutenbergViewController: UIViewController, PostEditor, PublishingEditor
private let editorViewController: GutenbergKit.EditorViewController
private weak var autosaveTimer: Timer?

var editorHasChanges: Bool {
var changes = post.changes
// TODO: cleanup (+ it doesn't handle scenarios like load from a revision)
// - warning: it has to compare two version serialized using the same system
if editorViewController.initialContent != post.content {
changes.content = post.content
} else {
changes.content = nil // yes, it needs to be set to .none manually
}
return !changes.isEmpty
}

// TODO: remove (none of these APIs are needed for the new editor)
var autosaver = Autosaver(action: {})
func prepopulateMediaItems(_ media: [Media]) {}
Expand Down

0 comments on commit ca4794e

Please sign in to comment.