-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to add single new-line when typing Shift + Enter #559
Comments
@iamthomasbishop I tested this on iOS and it works if you apply Shift+Enter in the middle of the paragraph/block. That said I did found a bug when you try to do this and the end of the paragraph that makes the system crash. |
@iamthomasbishop you are right the Shift+Enter it's only working when using a my laptop keyboard to do it, if I use the device touch keyboard I get the block split. |
@diegoreymendez may confirm but IIRC we tried something similar on aztec and this was impossible to detect on iOS on the screen keyboard |
This isn't supported in iOS. It's only possible through a hardware keyboard. |
Sorry, I closed this by mistake and reopened it. |
@diegoreymendez Fair enough. Just tested on Google Docs and Dropbox Paper and it's the same thing. So we can ax this issue for now if we need to. |
Shift-Enter with external keyboards would still be useful and perhaps even more when on tablets so, I'd leave this ticket open. @iamthomasbishop Is it OK with you to just rename it to "... on external keyboards"? |
FYI: Shift+Enter using external keyboards works correctly in iOS.
…On Thu, 14 Mar 2019 at 15:30, Stefanos Togoulidis ***@***.***> wrote:
Shift-Enter with external keyboards would still be useful and perhaps even
more when on tablets so, I'd leave this ticket open.
@iamthomasbishop <https://github.com/iamthomasbishop> Is it OK with you
to just rename it to "... on external keyboards"?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#559 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnxUVKVPfOM_KiSipHVDuSXVDhbX0Npks5vWmr9gaJpZM4anaTJ>
.
|
Let's find a workaround to enable users to input line breaks without paragraph split. It's really frustrating to do it when one really wants it, to nicely format small paragraphs like the following (think: a small poem. h/t @madeincosmos):
|
I noticed something that probably isn't directly helpful but might point the way for some possible solutions... On both Android and iOS it seems we can get soft-enter-like behavior sometimes if you type very quickly (not swipe) and then hit enter. The video below is from an Android release build not connected to the bundler (so I don't think it was just the result of a bundler delay, although I suspect it may still be related to the asynchronous communication across the bridge). I wasn't able to tell why it would sometimes give me a soft enter and sometimes not. |
Currently, pressing enter on image captions does create a new line instead of adding a new empty paragraph block. When addressing this, it would be good to give consistent behavior to the image caption as well. |
Noting that this came up in Slack and that Eli suggested possibly adding a button to the toolbar as a potential solution. (internal reference: p1602473723029700-slack-cellular-happiness) |
From an app review on Google Play
|
Another request in an app review on Google Play:
|
Requested in 3642791-zen.
|
3827600-zen
|
Another request in an app review on Google Play:
|
And another request in an app review on Google Play:
|
@iamthomasbishop tested and confirmed that shift+enter behavior works for both iPad and iPhones when accessing Gutenberg on the web. Combined with the fact that shift+enter works in the iOS notes app, this gives some hope that maybe something changed and maybe this is now possible. 🤞 |
It looks like it isn't currently possible to support Shift+Enter on iOS, more info below.
After a bit of investigation and collaboration on the team, we found that iOS only provides a public API for Shift key events when using an external (physical) keyboard via the Regarding mobile Safari, using JavaScript it's possible to detect the Shift key being pressed (although it doesn't seem possible to differentiate between it being held and being "on"). This won't help us here though, since Gutenberg Mobile uses something completely different, an Aztec ( An alternative here could be to invert the app's behavior and make soft new-lines the default when pressing Enter. That way, users could add a new Paragraph block when needed, otherwise they can press Enter to create a new line. |
Feedback from a user in 4410487-zd-woothemes:
|
3-star iOS app review
|
Another request in 4715088-zd-woothemes:
|
4745458-zen (translated):
|
4860430-zen User's idea: Hit Enter once for next line, twice for new block. |
Also mentioned in #4856871-zen:
|
Asked in 4940586-zd-woothemes:
|
From 1-star Google Play review:
|
|
Another user expecting this works on phone: #37318217-hc |
From a recent one star review:
|
Another user reported this 8567227-zd-a8c |
Current Behavior
Currently when I'm focused on a text block (paragraph, heading) and type
Shift + Enter
, a new block is created – which is the same behavior as typingEnter
.Expected Behavior
I expect that if I type
Shift + Enter
in a block, it should simply add a single new-line instead of creating a new block.Implementation coverage
The text was updated successfully, but these errors were encountered: