Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update maximum and default page_size for ListRequisitions and ListEventGroups #1916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SanjayVas
Copy link
Member

Closes #1915

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt line 453 at r1 (raw file):

  companion object {
    private const val DEFAULT_PAGE_SIZE = 10

shouldn't these ideally come from a config or a flag so that the market can define it based on the infra they have deployed/tuned?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)


src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt line 453 at r1 (raw file):

Previously, stevenwarejones (Steven Ware Jones) wrote…

shouldn't these ideally come from a config or a flag so that the market can define it based on the infra they have deployed/tuned?

No. As stated in the Slack thread, these should be fixed and the operator should ensure that their infra can handle these within given deadlines. These haven't yet been specified, but the default deadline of 30s was chosen to be above and beyond what should ever be hit in a functioning system.

These values also need to be documented in the API definition which is inherently not configurable (see AIP-158.

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum size for ListRequisitions, ListEventGroups results in response larger than gRPC limit
3 participants