Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update maximum and default page_size for ListRequisitions and ListEventGroups #1916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Update maximum and default page_size for ListRequisitions and ListEventGroups #1916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ bazel_dep(
)
bazel_dep(
name = "cross-media-measurement-api",
version = "0.69.0",
repo_name = "wfa_measurement_proto",
)
bazel_dep(
Expand Down Expand Up @@ -339,3 +338,13 @@ single_version_override(
module_name = "boringssl",
version = BORINGSSL_VERSION,
)

# DO_NOT_SUBMIT(world-federation-of-advertisers/cross-media-measurement-api#219): Use version.
archive_override(
module_name = "cross-media-measurement-api",
integrity = "sha256-CeYQfu6jxADBQNxLTUnVte3SECrkR4xquqC+3S1g6Ko=",
strip_prefix = "cross-media-measurement-api-54a1b1e226644fc4f74cc6bd5b7339178f93d104",
urls = [
"https://github.com/world-federation-of-advertisers/cross-media-measurement-api/archive/54a1b1e226644fc4f74cc6bd5b7339178f93d104.tar.gz",
],
)
5 changes: 1 addition & 4 deletions MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,8 @@ class EventGroupsService(private val internalEventGroupsStub: InternalEventGroup
}

companion object {
private const val DEFAULT_PAGE_SIZE = 50
private const val MAX_PAGE_SIZE = 1000
private const val DEFAULT_PAGE_SIZE = 10
private const val MAX_PAGE_SIZE = 500
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/RequisitionsService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ import org.wfanet.measurement.internal.kingdom.refuseRequisitionRequest
import org.wfanet.measurement.internal.kingdom.requisitionRefusal as internalRequisitionRefusal
import org.wfanet.measurement.internal.kingdom.streamRequisitionsRequest

private const val DEFAULT_PAGE_SIZE = 50
private const val MAX_PAGE_SIZE = 1000
private const val DEFAULT_PAGE_SIZE = 10
private const val MAX_PAGE_SIZE = 500

class RequisitionsService(private val internalRequisitionStub: RequisitionsCoroutineStub) :
RequisitionsCoroutineImplBase() {
Expand Down
Loading