Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes on some translations and compilations #433

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pbodq2
Copy link

@pbodq2 pbodq2 commented Jan 27, 2021

No description provided.

Remove non standarded area code file names.
Enrich translation content.
@pbodq2 pbodq2 changed the title Remove duplicated translation msgid Bug fixes on some translations and compilations Jan 27, 2021
ECO plugin conversion compatibility problems workarounds:
1.Relocate escape characters.
2.Change nested indent blocks into one singal line.
@@ -1,6 +1,6 @@
<div class="item-inner item-<%= @type %>">
<div class="artwork">
<div class="thumb" title="<%= @label %>" style="background-image: url('<%= @thumbnail %>')">
<div class="thumb" title="<%= @label %>" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)">
Copy link
Author

@pbodq2 pbodq2 Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#433

The web playlist is already fully broken in v19 RC1 Chorus2 v2.4.7 BEFORE I submit this change. This change is not dealing with that.
The web playlist in CoreELEC v9.2.5 with Kodi v18.9 , Chorus2 v2.4.6 is half broken. You can temp add items but items won't be saved into a new list form.

I may look into this part later and compare the code changes during these 2 years.

This type of escape character compilation errors exists on MACOS only, not author's Docker ubuntu dev, even though both platforms equipped with all the same library versions.
@pbodq2
Copy link
Author

pbodq2 commented Jan 28, 2021

#433

More information about "Fix ECO template compilation errors", these errors do not occur in author's Docker's container environment, i.e. node.js v8.12.0 npm v6.4.1

We can reproduce them in newer versions like node.js v14.15.4 npm v6.14.10 (all other package versions keep constant)

You guys may consider whether it is necessary to adopt it or leave it unchanged for better consistency.

@enen92
Copy link
Member

enen92 commented Mar 12, 2022

@gade01 now that this is translatable via weblate can you do the follow up to this issue and close it?

@gade01
Copy link
Contributor

gade01 commented Mar 12, 2022

@enen92
Yeah, language files should now be left out of this PR.
But I can see other stuff is changed as well, which probably should be left open and reviewed.

@pbodq2
Changes to these files are no longer needed as they are superseeded by #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants