Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes on some translations and compilations #433

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Bug fixes on some translations and compilations #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03a33f9
Enhance Simplified Chinese translation
pbodq2 Jan 27, 2021
d2c2549
Add Traditional Chinese translation support
pbodq2 Jan 27, 2021
e207849
Fix ECO template compilation errors
pbodq2 Jan 27, 2021
2b0941e
Fix ECO template compilation errors
pbodq2 Jan 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/apps/browser/list/tpl/file.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<div class="thumb" style="background-image: url('<%= @thumbnail %>')"><div class="mdi play"></div></div>
<div class="thumb" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)"><div class="mdi play"></div></div>
<div class="title" title="<%= helpers.global.stripTags(@labelHtml) %>"><%- @labelHtml %></div>
<ul class="actions">
<li class="menu dropdown">
Expand Down
2 changes: 1 addition & 1 deletion src/js/apps/lab/apiBrowser/tpl/api_method_page.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<% if @type is 'method': %>
<div class="api-method--execute">
<h3>Execute <strong><%= @method %></strong> with these params:</h3>
<textarea class="api-method--params" placeholder='Eg. ["arg", "foo", true]'></textarea>
<textarea class="api-method--params" placeholder="Eg. [<%= '\"' %>arg<%= '\"' %>, <%= '\"' %>foo<%= '\"' %>, true]"></textarea>
<p class="description">Parameters get parsed by
<a href="https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse" target="_blank">JSON.parse</a>.
Check the console for response objects, you will get an 'unexpected token' error if parsing failed.
Expand Down
2 changes: 1 addition & 1 deletion src/js/apps/playlist/list/tpl/playlist_item.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="item-inner item-<%= @type %>">
<div class="artwork">
<div class="thumb" title="<%= @label %>" style="background-image: url('<%= @thumbnail %>')">
<div class="thumb" title="<%= @label %>" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)">
Copy link
Author

@pbodq2 pbodq2 Jan 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#433

The web playlist is already fully broken in v19 RC1 Chorus2 v2.4.7 BEFORE I submit this change. This change is not dealing with that.
The web playlist in CoreELEC v9.2.5 with Kodi v18.9 , Chorus2 v2.4.6 is half broken. You can temp add items but items won't be saved into a new list form.

I may look into this part later and compare the code changes during these 2 years.

<div class="mdi play"></div>
<% if @canThumbsUp: %>
<div class="mdi thumbs"></div>
Expand Down
2 changes: 1 addition & 1 deletion src/js/apps/song/list/tpl/song.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<td class="cell-first">
<div class="thumb" style="background-image: url('<%= @thumbnail %>')">
<div class="thumb" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)">
</div>
<div class="track"><%= @track %></div>
<div class="mdi play"></div>
Expand Down
2 changes: 1 addition & 1 deletion src/js/components/form/tpl/form_item_imageselect.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<div class="pane active" rel="select">
<ul class="form-imageselect__thumbs">
<% if @image: %>
<li data-original="<%= @image.original %>" class="selected" style="background-image: url('<%= @image.thumb %>')"></li>
<li data-original="<%= @image.original %>" class="selected" style="background-image: url(<%= '\'' + @image.thumb + '\'' %>)"></li>
<% end %>
</ul>
<div class="form-imageselect__loader"><div class="loader-small-inline"></div> <span><%= tr('Searching for more images') %></span></div>
Expand Down
4 changes: 2 additions & 2 deletions src/js/helpers/translate.js.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ helpers.translate.getLanguages = ->
uk: "Ukrainian"
uz: "Uzbek"
vi: "Vietnamese"
zh_cn: "Chinese (Simplified)"
zh_tw: "Chinese (Traditional)"
zh_cn: "Chinese, Simplified"
zh_tw: "Chinese, Traditional"
}

## Init language and translations.
Expand Down
2 changes: 1 addition & 1 deletion src/js/views/card/tpl/card.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="card-<%= @type %>">
<div class="artwork">
<a href="#<%= @url %>" class="thumb" title="<%= helpers.global.stripTags(@labelHtml) %>" style="background-image: url('<%= @thumbnail %>')"></a>
<a href="#<%= @url %>" class="thumb" title="<%= helpers.global.stripTags(@labelHtml) %>" style="background-image: url(<%= '\'' + @thumbnail + '\'' %>)"></a>
<div class="mdi play" title="<%= tr('Play') %>"></div>
<% if @type is "channeltv" or @type is "channelradio": %>
<div class="mdi record"></div>
Expand Down
2 changes: 1 addition & 1 deletion src/js/views/layouts/tpl/layout_details_header.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
</div></div>

<% if @fanart: %>
<div class="region-details-fanart" style="background-image: url('<%= @fanart %>')"><div class="gradient"></div></div>
<div class="region-details-fanart" style="background-image: url(<%= '\'' + @fanart + '\'' %>)"><div class="gradient"></div></div>
<% end %>
</div>
7 changes: 1 addition & 6 deletions src/js/views/set/tpl/set.jst.eco
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@
<div class="set__header">
<h2 class="set__title"><%= @title %></h2>
<div class="set__actions">
<% if @menu: %>
<div class="dropdown">
<i data-toggle="dropdown" class="mdi"></i>
<ul class="dropdown-menu pull-right"></ul>
</div>
<% end %>
<% if @menu: %> <div class="dropdown"> <i data-toggle="dropdown" class="mdi"> </i> <ul class="dropdown-menu pull-right"> </ul> </div> <% end %>
</div>
</div>
<% end %>
Expand Down
Loading
Loading