Add custom JS to fix select all toggle on alerts list #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharsheblows
requested changes
Dec 23, 2024
classes/class-alerts-list.php
Outdated
| * Remove the WP core tags - suggest script on the alerts list screen. | ||
| * This is not needed, but more importantly it was breaking the select all functionality. | ||
| */ | ||
| wp_deregister_script( 'tags-suggest' ); |
There was a problem hiding this comment.
❗️issue
This causes the Alerts screen to not work for me. Which version of WP are you on? I've tested on 6.7.1 and 6.6.2.
There was a problem hiding this comment.
OMG, great catch 🤦🏻♂️. I have reverted that and added a few lines of JS to re-enable the select all toggle.
marcinkrzeminski
changed the title
There was a problem hiding this comment.
@marcinkrzeminski I think some extra files have gotten in. This is working for me now but those files should probably be removed.
tharsheblows
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
@marcinkrzeminski This looks good, thank you! There's a merge conflict but after that's resolved it's good to go.
…not-working # Conflicts: # ui/js/alerts-list.js
marcinkrzeminski
deleted the
fix/1661-select-all-alerts-in-table-view-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1661
It turned the
inline-edit-postscript which is a dependency forwp-stream-alertshas atags-suggestas a dependency which was causing issues with select all on the Alerts list screen. The solution was to deregister that script on that screen.Checklist
contributing.md).Release Changelog