Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom JS to fix select all toggle on alerts list #1665

Merged
6 changes: 6 additions & 0 deletions classes/class-alerts-list.php
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,12 @@ public function enqueue_scripts() {
return;
}

/**
* Remove the WP core tags - suggest script on the alerts list screen.
* This is not needed, but more importantly it was breaking the select all functionality.
*/
wp_deregister_script( 'tags-suggest' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️issue
This causes the Alerts screen to not work for me. Which version of WP are you on? I've tested on 6.7.1 and 6.6.2.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, great catch 🤦🏻‍♂️. I have reverted that and added a few lines of JS to re-enable the select all toggle.


$min = wp_stream_min_suffix();

wp_register_script(
Expand Down