changed interaction to only one interaction point #406
Conversation
|
See my changes for review. Now that all interactions are in one place we can decide what is better: Option A (all together) or Option B (grouped by Addon). How do you think about it @GermanHydrogen
|
| _handle = [_battery] spawn AE3_power_fnc_checkBatteryLevelAction; | ||
| }, | ||
| {alive _target}, | ||
| {}, | ||
| [_battery] | ||
| ] call ace_interact_menu_fnc_createAction; | ||
|
|
||
| [_entity, 0, ["ACE_MainActions", "AE3_DeviceAction"], _check] call ace_interact_menu_fnc_addActionToObject; | ||
| private _parentActionPath = _entity getVariable ["AE3_parentActionPath", ""]; |
There was a problem hiding this comment.
Is the default a valid input for ace_interact_menu_fnc_addActionToObject?
We should decide if we want to recover here if AE3_parentActionPath is not set, so to just use the "ACE_MainActions" as a parent, or if we want to throw an exception in this case
| _actions; | ||
| }; | ||
| params ["_target", "_player", "_params"]; | ||
| (_params select 0) params ["_index", "_name", "_rel_pos", "_rot_yaw", "_rot_pitch", "_rot_roll"]; |
There was a problem hiding this comment.
| (_params select 0) params ["_index", "_name", "_rel_pos", "_rot_yaw", "_rot_pitch", "_rot_roll"]; | |
| private _driveInfo = _params select 0; | |
| if !(_driveInfo isEqualType []) then { | |
| _driveInfo = _params select 1; | |
| }; | |
| _driveInfo params ["_index", "_name", "_rel_pos", "_rot_yaw", "_rot_pitch", "_rot_roll"]; |
There was a problem hiding this comment.
Thanks to Dystopian's acemod/ACE3#9946, this rough fix won't be necessary, the next ACE3 Patch version will resolve the issue.
There was a problem hiding this comment.
This has now been fixed publicly by ACE v3.17.1.
Merging this Pull Request will merge the different AE3 interaction points into one interaction menu. So there are no more doubled "Laptop" interaction points and also the interaction to access armaOS or attach USB flash drive were merged into the main interaction menu.