Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken tests on GitHub actions. #30

Merged
merged 8 commits into from
Oct 16, 2024
Merged

Conversation

robin-ynput
Copy link

Changelog Description

While everything still works fine locally, LabLib tests as GitHub action seems suddenly broken since a couple of weeks:

After some investigation I realized the culprit seems to come from a recent OpenColorIO Release 2 weeks ago.
Fixing it back to the previous version seems to make it work back.

@jakubjezek001 @tweak-wtf, I'm not sure this is the best fix for the long-term but I cannot find have anything better for now.

Additional info

Issue is quite weird:

Run .\start.ps1 test
Windows fatal exception: access violation

Current thread 0x00001304 (most recent call first):
  File "<frozen importlib._bootstrap>", line 228 in _call_with_frames_removed
  File "<frozen importlib._bootstrap_external>", line [11](https://github.com/ynput/LabLib/actions/runs/11352264466/job/31574650242#step:9:12)73 in create_module

And what I could find on Google was not very meaningful.
spyder-ide/spyder#20909
pytest-dev/pytest#7634

Testing notes:

GitHub actions are now working.

@robin-ynput robin-ynput self-assigned this Oct 15, 2024
@robin-ynput robin-ynput linked an issue Oct 15, 2024 that may be closed by this pull request
@robin-ynput robin-ynput marked this pull request as ready for review October 15, 2024 20:27
@robin-ynput robin-ynput added the bug Something isn't working label Oct 15, 2024
@tweak-wtf
Copy link
Collaborator

good catch with the PyOpenColorIO dependency!
i believe it's fine to version lock this. what do u say @jakubjezek001 ?
the issue might be the added support for the new ACES 2.0. as the release notes say this is a preview release so likely receiving updates. check this -> https://opencolorio.readthedocs.io/en/latest/releases/ocio_2_4.html#aces-2-0-output-transforms-preview-release

when they've release a new revision of this we can give it another try.

@robin-ynput
Copy link
Author

good catch with the PyOpenColorIO dependency! i believe it's fine to version lock this. what do u say @jakubjezek001 ? the issue might be the added support for the new ACES 2.0. as the release notes say this is a preview release so likely receiving updates. check this -> https://opencolorio.readthedocs.io/en/latest/releases/ocio_2_4.html#aces-2-0-output-transforms-preview-release

when they've release a new revision of this we can give it another try.

Hey @tweak-wtf thanks for you feedback.
Jakub is off for a few more days, should we wait for him to go back ? or do you prefer me to go ahead and merge this ?
I'm happy to fill up an issue so do not forget to revisit this on next opencolorio release.

@tweak-wtf
Copy link
Collaborator

alrighty. in that case i would suggest to define the dependency like this opencolorio = "<=2.3.2" and let the tests run again.
that way we're not hard-locking the dependency but allow for older versions as well if needed. whether they're supported is another question then.

i think that way we're safe to merge this.

@robin-ynput robin-ynput merged commit bd664a8 into develop Oct 16, 2024
2 checks passed
@robin-ynput robin-ynput deleted the maintenance/fix_gh_tests branch October 16, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AY-1270_Circuit: Extracting HTML slates via LabLib
2 participants