eslint 9 & misc dependency updates #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djahandarie
force-pushed
the
more-dependency-updates
branch
from
e276ddd to
330a375
Compare
djahandarie
changed the title
CodSpeed Performance ReportMerging #1712 will not alter performanceComparing Summary
|
djahandarie
added
area/ci
djahandarie
commented
Dec 28, 2024
| { | ||
| files: [ | ||
| 'ext/js/templates/template-renderer-frame-main.js', | ||
| ...await getDependencies(['ext/js/templates/template-renderer-frame-main.js']), |
There was a problem hiding this comment.
Lines like these are what allows us to safely get rid of eslint-config.test.js.
MarvNC
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to eslint 9 was exceptionally complex due to the config file format changed from a JSON file to a JS file which gets dynamically created.
https://eslint.org/docs/latest/use/configure/migration-guide
https://eslint.org/blog/2022/08/new-config-system-part-2/
On the bright side this allowed us to dynamically calculate the dependency graph for each of the different contexts we have and set appropriate globals for each of them, which allows us to eliminate the eslint-config test, which did that calculation post-hoc, which simplifies things a bit and also speeds up our tests.