Fix DataStorm filter initialization #3277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
commented
Dec 16, 2024
cpp/include/DataStorm/InternalT.h
Outdated
| @@ -439,13 +439,18 @@ namespace DataStormI | |||
|
|
|||
| template<typename FF> void init(const std::string& name, FF&& lambda) | |||
| { | |||
| _name = name; | |||
| _lambda = std::forward<FF>(lambda); | |||
| std::unique_lock lock(_mutex); | |||
There was a problem hiding this comment.
I’m thinking the mutex is probably not required, the factory is owned by the topic instance and the instances cannot be shared between threads
There was a problem hiding this comment.
If it's not required, you should add a comment instead of a mutex. And clearly the other functions (getName etc.) don't use a mutex.
cpp/include/DataStorm/InternalT.h
Outdated
| @@ -439,13 +439,18 @@ namespace DataStormI | |||
|
|
|||
| template<typename FF> void init(const std::string& name, FF&& lambda) | |||
| { | |||
| _name = name; | |||
| _lambda = std::forward<FF>(lambda); | |||
| std::unique_lock lock(_mutex); | |||
There was a problem hiding this comment.
If it's not required, you should add a comment instead of a mutex. And clearly the other functions (getName etc.) don't use a mutex.
| _name = name; | ||
| _lambda = std::forward<FF>(lambda); | ||
| std::unique_lock lock(_mutex); | ||
| if (!_lambda) |
There was a problem hiding this comment.
The logic is init can be called multiple times? This deserves a comment since it's unexpected with a function named init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2926