[16.0][MIG] l10n_eu_nace #176

Abranes · 2023-10-29T15:06:59Z

Standard migration to 16.0

…anslations

Short category names are now displayed on partner views, since NACE names are so long

Data files were there, but translations were not.

[ADD] setup.py

[12.0][IMP] - Add unit tests [IMP] - code improve Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/migrations/12.0.2.0.0/pre-migration.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/migrations/12.0.2.0.0/post-migration.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/views/res_partner.xml Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/readme/CONTRIBUTORS.rst Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> [FIX] - fix code Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> [FIX] - Fix name_search

Fix post-migration Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]> Update l10n_eu_nace/models/res_partner_nace.py Co-authored-by: Jairo Llopis <[email protected]>

Some need to add secondary NACE codes to partners. This is a very little addition, possibly quite standard, so it's done directly in the base addon. @Tecnativa TT17678

FIX + IMP : more readable query for updating partners with new xml_id regarding old xml_id

Currently translated at 100.0% (868 of 868 strings) Translation: community-data-files-14.0/community-data-files-14.0-l10n_eu_nace Translate-URL: https://translation.odoo-community.org/projects/community-data-files-14-0/community-data-files-14-0-l10n_eu_nace/fr/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: community-data-files-14.0/community-data-files-14.0-l10n_eu_nace Translate-URL: https://translation.odoo-community.org/projects/community-data-files-14-0/community-data-files-14-0-l10n_eu_nace/

flotho · 2023-10-29T16:32:36Z

hum... runboat not available! issued a 404

Abranes · 2023-10-29T21:27:08Z

hum... runboat not available! issued a 404

It works for me, can you try it one more time?

flotho

functionnal test OK,
LGTM

iziwas · 2023-11-09T10:57:39Z

Hi,

Thanks for the PR request.
Functional tests are OK for me too. However, I have a warning about parent_path field in res.parter.nace : "parent_path field on model 'res.partner.nace' should have unaccent disabled. Add unaccent=False to the field definition."

Is it possible to fix it before please ?

yajo

After analyzing this module, I think it needs a refactor. Please let me explain.

This module introduces a duplicate structure in Odoo. Odoo CE already has a res.partner.industry model. In OCA, the partner_industry_secondary module implements:

Parent-child relationship.
Many2many relation between res.partner and res.partner.industry.

So, if this module depends on partner_industry_secondary, which is already migrated to v16, we can drop most of the code. This would just contain the NACE codes in CSV, which would be declared in the manifest and loaded at install; period.

IMHO the migration is probably the best opportunity to do it, as this involves structural changes in the data model. It would mean directly dropping all xml and python code from here, so I think it's a simple refactor that'd be very helpful.

FWIW the only "complex" thing would be a migration script, which wouldn't be very complex anyways.

WDYT?

Rad0van · 2023-11-28T13:38:27Z

After analyzing this module, I think it needs a refactor. Please let me explain.

This module introduces a duplicate structure in Odoo. Odoo CE already has a res.partner.industry model. In OCA, the partner_industry_secondary module implements:

Parent-child relationship.

Many2many relation between res.partner and res.partner.industry.

So, if this module depends on partner_industry_secondary, which is already migrated to v16, we can drop most of the code. This would just contain the NACE codes in CSV, which would be declared in the manifest and loaded at install; period.

IMHO the migration is probably the best opportunity to do it, as this involves structural changes in the data model. It would mean directly dropping all xml and python code from here, so I think it's a simple refactor that'd be very helpful.

FWIW the only "complex" thing would be a migration script, which wouldn't be very complex anyways.

WDYT?

Looking at the modules I totally agree with you.

pedrobaeza · 2023-11-28T14:32:21Z

The only problem I see is that the industry model already contains other records that are not NACE ones.

Rad0van · 2023-11-28T14:35:57Z

The only problem I see is that the industry model already contains other records that are not NACE ones.

Which ones? By quickly looking (at least for v16) it seems right to me...

pedrobaeza · 2023-11-28T14:37:22Z

I mean these ones:

https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/data/res_partner_data.xml#L57-L160

Rad0van · 2023-11-28T14:44:23Z

I mean these ones:

https://github.com/odoo/odoo/blob/16.0/odoo/addons/base/data/res_partner_data.xml#L57-L160

Yes, but these are the main existing NACE groups. See https://en.wikipedia.org/wiki/Statistical_Classification_of_Economic_Activities_in_the_European_Community or https://nacev2.com/en

pedrobaeza · 2023-11-28T17:39:59Z

Ok then. Just a proper mapping should be done for recognizing them as the parents.

yajo · 2023-11-29T09:49:40Z

partner_industry_secondary makes the parent-child relationship possible, so it shouldn't be a big problem, apart from a relatively simple migration script.

cvinh · 2024-02-03T05:58:45Z

Hello @Abranes, are you going to change your PR according to comments above ?

rafaelbn · 2024-02-21T22:49:00Z

/ocabot migration l10n_eu_nace

OCA-git-bot · 2024-02-21T22:49:27Z

Sorry @rafaelbn you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

edlopen · 2024-04-15T19:21:56Z

I have an open PR that uses the res.parter.industry as @yajo said here. And also updated the module so that it uses the new ShowVoc Endpoint as the RAMON servers are deprecated.

yajo · 2024-04-17T12:36:41Z

Thanks! Closing here, as the other PR is more suited for merge.

rafaelbn · 2024-08-07T12:27:58Z

Migrated in #196

Numerigraphe - Lionel Sausin and others added 30 commits October 28, 2023 12:01

[ADD] l10n_eu_nace: add European Union statistical partner categories

18bf550

[IMP] l10n_eu_nace: let users search for NACE codes ommiting the "."

57fbeb4

[REF] Cosmetics

d9b648b

[IMP] l10n_eu_nace: generate .pot file along with translations

51cbdfb

[FIX] l10n_eu_nace used country codes instead of language codes in tr…

c97b682

…anslations

[IMP] Update to v7.0 coding standard

5338ede

[IMP] PEP8

50cc24f

move addons to __unported__

be95bea

[IMP] ported l10n_eu_nace to v8

30e9237

Short category names are now displayed on partner views, since NACE names are so long

[UPD] prefix versions with 8.0

0c1c7b7

[MIG] Make modules uninstallable

a2d7dd6

Port l10n_eu_nace to v9

13bb0f4

Migrate to new api

d91c1cd

Finalize migration to new api

2215ffd

Fix pep8

dab8f66

remove +x flag on partner.py

dec115e

[MIG] Make modules uninstallable

76d7a49

[MIG] Rename manifest files

aa4ccb9

[MIG] l10n_eu_nace : Migrated to 10.0

2cdc575

[FIX][l10n_eu_nace] Add missing languages.

4c87264

Data files were there, but translations were not.

remove obsolete .pot files [ci skip]

0c7d07f

[MIG] - migration l10n_eu_nace to 12.0

d5c7b94

[ADD] setup.py

[FIX] - use computed name for complete name

5a4f160

[IMP] - make short name as default

cc5756b

[RMV] - remove broken files

d07a9b7

[IMP] l10n_eu_nace: add secondary

fc654a8

Some need to add secondary NACE codes to partners. This is a very little addition, possibly quite standard, so it's done directly in the base addon. @Tecnativa TT17678

FIX : Bad type in pre migration with boolean attribute

36b2d9d

FIX + IMP : more readable query for updating partners with new xml_id regarding old xml_id

FIX Pylint

2844157

Ernesto Tejeda and others added 9 commits October 28, 2023 12:01

[MIG] l10n_eu_nace: Migration to 14.0

bc57c64

[UPD] Update l10n_eu_nace.pot

441f613

[UPD] README.rst

969a448

Added translation using Weblate (Croatian)

a20e482

[UPD] README.rst

3015602

[IMP] l10n_eu_nace: pre-commit stuff

015e087

[16.0][MIG] l10n_eu_nace: Migration to 16.0

1ef031a

flotho approved these changes Oct 30, 2023

View reviewed changes

yajo requested changes Nov 27, 2023

View reviewed changes

aronabencherif mentioned this pull request Apr 4, 2024

Improve migration 16.0 l10n eu nace #195

Closed

edlopen mentioned this pull request Apr 15, 2024

[16.0][MIG] l10n_eu_nace new ShowVoc integration #196

Merged

yajo closed this Apr 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] l10n_eu_nace #176

[16.0][MIG] l10n_eu_nace #176

Abranes commented Oct 29, 2023

flotho commented Oct 29, 2023 •

edited

Loading

Abranes commented Oct 29, 2023

flotho left a comment

iziwas commented Nov 9, 2023

yajo left a comment

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

yajo commented Nov 29, 2023

cvinh commented Feb 3, 2024

rafaelbn commented Feb 21, 2024

OCA-git-bot commented Feb 21, 2024

edlopen commented Apr 15, 2024

yajo commented Apr 17, 2024

rafaelbn commented Aug 7, 2024

[16.0][MIG] l10n_eu_nace #176

[16.0][MIG] l10n_eu_nace #176

Conversation

Abranes commented Oct 29, 2023

flotho commented Oct 29, 2023 • edited Loading

Abranes commented Oct 29, 2023

flotho left a comment

Choose a reason for hiding this comment

iziwas commented Nov 9, 2023

yajo left a comment

Choose a reason for hiding this comment

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

Rad0van commented Nov 28, 2023

pedrobaeza commented Nov 28, 2023

yajo commented Nov 29, 2023

cvinh commented Feb 3, 2024

rafaelbn commented Feb 21, 2024

OCA-git-bot commented Feb 21, 2024

edlopen commented Apr 15, 2024

yajo commented Apr 17, 2024

rafaelbn commented Aug 7, 2024

flotho commented Oct 29, 2023 •

edited

Loading