Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use approx for comparing timestep and final time #26

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Use approx for comparing timestep and final time #26

merged 1 commit into from
Apr 28, 2022

Conversation

jbwillis
Copy link
Contributor

Avoids having numerical precision errors on the time check.

@jbwillis jbwillis requested a review from bjack205 April 28, 2022 18:13
bjack205
bjack205 approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@bjack205 bjack205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjack205 bjack205 merged commit 6ea2482 into master Apr 28, 2022
@bjack205 bjack205 deleted the tf_assert_fix branch April 28, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjack205 bjack205 bjack205 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbwillis @bjack205