Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add builder type for session launchers #3491

Merged
merged 28 commits into from
Feb 24, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 17, 2025

PR stack:

Closes #3490.

Add support for repository-backed session environments.

Note that, at this stage, images are not being built and that the UI is not checking the build status of the session environment yet.

/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources

@leafty leafty temporarily deployed to renku-ci-ui-3491 January 17, 2025 14:40 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3491.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3491 January 17, 2025 16:39 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 20, 2025 10:31 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 20, 2025 15:41 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 21, 2025 08:14 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 27, 2025 10:12 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 27, 2025 14:31 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 January 31, 2025 07:54 — with GitHub Actions Inactive
@leafty leafty force-pushed the build/session-env-builders branch from 67b25e4 to f99e4be Compare February 3, 2025 09:44
@leafty leafty temporarily deployed to renku-ci-ui-3491 February 3, 2025 09:48 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 February 3, 2025 10:09 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3491 February 24, 2025 08:21 — with GitHub Actions Inactive
@leafty
Copy link
Member Author

leafty commented Feb 24, 2025

@andre-code

When editing a custom + build environment, the advanced settings form displays. Why is it not shown when creating the launcher?

The advanced settings are not editable for now when selecting "Create from a code repository". The values (e.g. port, URL path, uid, gid) are configured by the backend.

I couldn't test the functionality in the current deployment due to an error

The value of the option changed in the backend. Fixed now.

@leafty leafty requested a review from andre-code February 24, 2025 08:37
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I noticed a couple of issues while testing:

  • Once the launcher is created, if the user tries to modify it, the advanced fields are visible. However, updating those values in the form does not reflect the changes in the environment card, and the values don't seem to be saved. Is this the expected behavior?

If the container image needs to exist first, perhaps those fields shouldn't be available to avoid confusion.

  • There is a bug in the custom + build case. When updating a value in the edit form, the repository is unexpectedly changed when saving the form.

launcher custom build

@leafty leafty temporarily deployed to renku-ci-ui-3491 February 24, 2025 14:41 — with GitHub Actions Inactive
@leafty
Copy link
Member Author

leafty commented Feb 24, 2025

  • Once the launcher is created, if the user tries to modify it, the advanced fields are visible. However, updating those values in the form does not reflect the changes in the environment card, and the values don't seem to be saved. Is this the expected behavior?

If the container image needs to exist first, perhaps those fields shouldn't be available to avoid confusion.

Advanced settings removed. They were removed in a later PR. This PR was created before the backend was ready and it was known that users cannot edit the advanced settings.

  • There is a bug in the custom + build case. When updating a value in the edit form, the repository is unexpectedly changed when saving the form.

Can you post which browser you are using? I cannot reproduce this issue. When I select the edit option, the selected repository is the one that was saved before.

Fixed in 2fb83cf.

@leafty leafty requested a review from andre-code February 24, 2025 15:03
@leafty leafty temporarily deployed to renku-ci-ui-3491 February 24, 2025 15:03 — with GitHub Actions Inactive
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @leafty 🎉 I tested the feature, and it successfully creates/edit the custom + build launcher as expected.

@leafty leafty merged commit 8f23ed4 into build/session-env-builders Feb 24, 2025
11 of 12 checks passed
@leafty leafty deleted the leafty/session-env-builders-1 branch February 24, 2025 15:49
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants