-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add builder type for session launchers #3491
feat: add builder type for session launchers #3491
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3491.dev.renku.ch |
67b25e4
to
f99e4be
Compare
… leafty/session-env-builders-1
The advanced settings are not editable for now when selecting "Create from a code repository". The values (e.g. port, URL path, uid, gid) are configured by the backend.
The value of the option changed in the backend. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once I noticed a couple of issues while testing:
- Once the launcher is created, if the user tries to modify it, the advanced fields are visible. However, updating those values in the form does not reflect the changes in the environment card, and the values don't seem to be saved. Is this the expected behavior?
If the container image needs to exist first, perhaps those fields shouldn't be available to avoid confusion.
- There is a bug in the custom + build case. When updating a value in the edit form, the repository is unexpectedly changed when saving the form.
Advanced settings removed. They were removed in a later PR. This PR was created before the backend was ready and it was known that users cannot edit the advanced settings.
Fixed in 2fb83cf. |
fa5b557
to
2fb83cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @leafty 🎉 I tested the feature, and it successfully creates/edit the custom + build launcher as expected.
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR stack:
Closes #3490.
Add support for repository-backed session environments.
Note that, at this stage, images are not being built and that the UI is not checking the build status of the session environment yet.
/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources