-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show last build's logs #3534
feat: show last build's logs #3534
Conversation
You can access the deployment of this PR at https://renku-ci-ui-3534.dev.renku.ch |
cda43c4
to
6fa806d
Compare
8f89df2
to
2d79a72
Compare
6fa806d
to
042c2e9
Compare
2d79a72
to
92fdbbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful addition for debugging!
I dropped a suggestion (see online). Otherwise, it's good to go 👍
92fdbbb
to
652cf35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! 🚀
Side note: I made a test project a few days ago with a launcher created from code (on the right in the screenshot). To my surprise, today I looked at it and it became a custom environment 🤯 I can still make a new environment from code and it looks fine (left). I'm sure I didn't change anything and I'm wondering if there is something else that might potentially lead to this unexpected conversion (DB migration or something?). Perhaps this just happened once, or I messed up things somehow, but I thought it's better to report to keep an eye on it
No, it's because I rolled backend migrations back and forth. |
Tearing down the temporary RenkuLab deplyoment for this PR. |
PR stack:
Add an action to retrieve the logs from the last build (or the current build if a build is in progress).
Also, improve the build actions logic.
/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources renku-notebooks=leafty/shipwright-buildrun-cache extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.pushSecretName=flora-docker-secret,dataService.imageBuilders.buildRunRetentionAfterFailedSeconds=86400,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/flora-dev/