Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show last build's logs #3534

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Feb 19, 2025

PR stack:

Add an action to retrieve the logs from the last build (or the current build if a build is in progress).

Also, improve the build actions logic.

Screenshot From 2025-02-24 15-05-23
Screenshot From 2025-02-24 15-06-01

/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources renku-notebooks=leafty/shipwright-buildrun-cache extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.pushSecretName=flora-docker-secret,dataService.imageBuilders.buildRunRetentionAfterFailedSeconds=86400,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/flora-dev/

@leafty leafty temporarily deployed to renku-ci-ui-3534 February 19, 2025 12:01 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3534.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3534 February 19, 2025 13:37 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3534 February 19, 2025 13:52 — with GitHub Actions Inactive
@leafty leafty temporarily deployed to renku-ci-ui-3534 February 20, 2025 10:18 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/session-env-builders-5 branch from cda43c4 to 6fa806d Compare February 24, 2025 12:36
@leafty leafty force-pushed the leafty/session-env-builders-6 branch from 8f89df2 to 2d79a72 Compare February 24, 2025 13:54
@leafty leafty temporarily deployed to renku-ci-ui-3534 February 24, 2025 13:56 — with GitHub Actions Inactive
@leafty leafty marked this pull request as ready for review February 24, 2025 14:06
@leafty leafty requested a review from a team as a code owner February 24, 2025 14:06
@leafty leafty temporarily deployed to renku-ci-ui-3534 February 24, 2025 14:06 — with GitHub Actions Inactive
@leafty leafty force-pushed the leafty/session-env-builders-5 branch from 6fa806d to 042c2e9 Compare February 24, 2025 16:00
@leafty leafty force-pushed the leafty/session-env-builders-6 branch from 2d79a72 to 92fdbbb Compare February 24, 2025 16:02
@leafty leafty temporarily deployed to renku-ci-ui-3534 February 24, 2025 16:02 — with GitHub Actions Inactive
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful addition for debugging!
I dropped a suggestion (see online). Otherwise, it's good to go 👍

@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Feb 25, 2025
Base automatically changed from leafty/session-env-builders-5 to build/session-env-builders February 27, 2025 08:14
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! 🚀

Side note: I made a test project a few days ago with a launcher created from code (on the right in the screenshot). To my surprise, today I looked at it and it became a custom environment 🤯 I can still make a new environment from code and it looks fine (left). I'm sure I didn't change anything and I'm wondering if there is something else that might potentially lead to this unexpected conversion (DB migration or something?). Perhaps this just happened once, or I messed up things somehow, but I thought it's better to report to keep an eye on it

Screenshot_20250227_104121

@leafty
Copy link
Member Author

leafty commented Feb 27, 2025

Side note: I made a test project a few days ago with a launcher created from code (on the right in the screenshot). To my surprise, today I looked at it and it became a custom environment 🤯 I can still make a new environment from code and it looks fine (left). I'm sure I didn't change anything and I'm wondering if there is something else that might potentially lead to this unexpected conversion (DB migration or something?). Perhaps this just happened once, or I messed up things somehow, but I thought it's better to report to keep an eye on it

No, it's because I rolled backend migrations back and forth.

@leafty leafty merged commit 032970b into build/session-env-builders Feb 27, 2025
12 checks passed
@leafty leafty deleted the leafty/session-env-builders-6 branch February 27, 2025 10:01
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants