-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add app params for image builders #3511
Open
leafty
wants to merge
6
commits into
build/session-env-builders
Choose a base branch
from
leafty/session-env-builders-3
base: build/session-env-builders
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can access the deployment of this PR at https://renku-ci-ui-3511.dev.renku.ch |
8bc0bd6
to
b40d8f2
Compare
leafty
commented
Feb 24, 2025
7d1fcb3
to
d1db556
Compare
This was referenced Feb 24, 2025
409135f
to
dab89e8
Compare
This was referenced Feb 24, 2025
737a305
to
c9cd8e5
Compare
d1db556
to
bd66139
Compare
88b23f8
to
61691f4
Compare
bd66139
to
8216f6c
Compare
61691f4
to
b7ba96e
Compare
Base automatically changed from
leafty/session-env-builders-7
to
build/session-env-builders
February 27, 2025 15:07
2940c3d
to
688a6c5
Compare
leafty
commented
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure the UI for session image builds based on the helm chart values.
IMAGE_BUILDERS_ENABLED==true
, then the "Create from code" option for session launchers is available.IMAGE_BUILDERS_ENABLED==false
, then the "Create from code" option for session launchers is not shown to users.Deployments:
/deploy #notest renku=build/session-env-builders renku-data-services=kpack-resources renku-notebooks=leafty/shipwright-buildrun-cache extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.pushSecretName=flora-docker-secret,dataService.imageBuilders.buildRunRetentionAfterFailedSeconds=86400,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/flora-dev/