Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add support to use router general for router id #4687

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Nov 6, 2024

Change Summary

Add support to use router general for router id.

Related Issue(s)

Fixes #1245

Component(s) name

arista.avd.eos_designs

Proposed changes

Starting EOS 4.22.1F (https://eos.arista.com/eos-4-22-1f/general-router-id/) we support to set global router-id which can inherited to all BGP VRFs. Currently, AVD add router-id knob per VRF, which is suboptimal comparing to single global router-id config.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Nov 6, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4687
# Activate the virtual environment
source test-avd-pr-4687/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/eos_designs/router-general-router-id#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/router-general-router-id --force
# Optional: Install AVD examples
cd test-avd-pr-4687
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Nov 6, 2024
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch 3 times, most recently from a60d675 to a2da7e8 Compare November 6, 2024 05:54
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch 7 times, most recently from 0c43724 to 66e4de9 Compare November 11, 2024 09:00
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch from 66e4de9 to 1bdab3b Compare November 11, 2024 09:03
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review November 11, 2024 09:21
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch from 7b3a35a to 82e8faa Compare November 11, 2024 14:53
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch from 82e8faa to 9a10987 Compare November 11, 2024 14:59
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch from 9a10987 to 23dbfae Compare November 11, 2024 15:04
@laxmikantchintakindi laxmikantchintakindi force-pushed the feat/eos_designs/router-general-router-id branch from 1b7589c to d86885b Compare November 11, 2024 15:17
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Nov 11, 2024
@ClausHolbechArista ClausHolbechArista requested a review from a team November 11, 2024 15:51
Copy link

sonarcloud bot commented Nov 12, 2024

@gmuloc gmuloc merged commit 48a0b7e into aristanetworks:devel Nov 12, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add router general router-id ipv4 knob
3 participants