Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runtime component to use manifests #130

Merged
merged 41 commits into from
Aug 23, 2024
Merged

Update runtime component to use manifests #130

merged 41 commits into from
Aug 23, 2024

Conversation

patrickpa
Copy link
Contributor

@patrickpa patrickpa commented Aug 21, 2024 •
edited
Loading

Description

This PR adds the concept of manifest files for the runtime Python module.

The runtime now expects a framework manifest that lists all the module manifests to be executed.

The module will follow the execution described in the runtime manual based on the configuration parameter.

Main changes

  1. Update module to read execution list from manifest file
  2. Add manifests validation
  3. Add runtime execution based on manifest
  4. Update demo pipeline to use new runtime version
  5. Update tests to use new runtime version

How was the PR tested?

  1. Executed the runtime using local manifests to provide the desired output.
  2. Executed the demo pipeline using the new runtime version.
  3. Unit-tests are passing as intended.

Notes

  • None.

@patrickpa
Add initial pyproject.toml
0bdc15d 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add base models for manifests
490eeb1 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update runtime requirements
4ad7bc5 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add initial implementation with manifest
c5018c1 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add working version of runtime and manifests
aa52e63 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add output folder creation
367b872 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update output folder with decimal date part
23351ac 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove lxml from direct requirements
5bb7fb0 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa patrickpa self-assigned this Aug 21, 2024
@patrickpa
Update tests for runtime module with manifests
188da6a 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Temporary remove test build condition
ca9ef01 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add baselib to base requirements
464605e 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix demo checker bundle manifest for tests
724c357 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Revert workflow test
c63e3b0 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Reanable run runtime test on every commit
463b9a3 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update logic to run from config instead of manifest
c5e1382 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix text report manifest to handle config
daee0f8 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove requirements.txt
a4463ec 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update runtime test workflow with proper pip install
449e1fa 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add poetry to runtime exec test
c9f3b87 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update poetry install with dev dependencies
443d206 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update poetry lock
69dd17a 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add latest version for qc base lib
e8d3961 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Merge docker changes from develop branch
5d1fed2 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update linux bare ubuntu version
8b9246a 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update runtime test on windows workflow
326b54d 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add complete path to poetry executable on windows
586c193 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Test relative env to app data
fd317f8 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Test with start process on windows workflow
ff08a11 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Test windows runtime tests with default python
b8ff20d 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add windows and linux test separation
81b6871 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix runtime tests on docker linux
881cb45 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Add check for duplicated entry on runtime
cb008e3 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Adjust windows manifests commands
98077af 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update windows commands with quoted for relative path
cbeebad 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update windows manifest for cmd syntax
2bb4f15 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Fix relative path for binaries on windows manifests
761016a 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Enable default events for runtime
a9c2950 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update demo pipeline to use manifest version of runtime
cf63aed 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update demo pipeline to use direct installation instead of custom exe…
8f8bc7e 
…cutables

Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Update runtime error messages
1e1ac11 
Signed-off-by: Patrick Abrahão <[email protected]>
@patrickpa
Remove custom executables from docker image
75be75e 
Signed-off-by: Patrick Abrahão <[email protected]>
hoangtungdinh
hoangtungdinh approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@hoangtungdinh hoangtungdinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Thanks @patrickpa

@hoangtungdinh hoangtungdinh merged commit 30bfea9 into develop Aug 23, 2024
4 checks passed
@hoangtungdinh hoangtungdinh deleted the patrick/add_manifest_to_runtime branch August 23, 2024 10:20
hoangtungdinh pushed a commit that referenced this pull request Aug 28, 2024
@patrickpa @hoangtungdinh
Update runtime component to use manifests (#130)
5018435 
Signed-off-by: Patrick Abrahão <[email protected]>
@hoangtungdinh hoangtungdinh mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangtungdinh hoangtungdinh hoangtungdinh approved these changes

Assignees

@patrickpa patrickpa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickpa @hoangtungdinh