Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autoware_core_component_interface_specs package #124

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Dec 12, 2024

Description

This creates a new autoware_core_component_interface_specs package in to Autoware Core.
This package is based on autoware_component_interface_specs. The main differences are the followings:

  • remove any interfaces from autoware_tier4_msgs since these are not official interface defined by AWF
  • remove ADAPI interfaces. Phase 1 of Autoware Core would be simple so I removed them for simplicity.
  • Add base class for interface definition with get_qos() function. Autoware Universe has autoware_interface_utils to provide similar utility function, but I thought that was too overwhelming for Autoware Core so I just provided the simple interface to help users declare publishers and subscribers.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Dec 12, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mitsudome-r mitsudome-r force-pushed the add-autoware-component-interface-specs branch 2 times, most recently from 3f92a0e to 8aba5d9 Compare December 12, 2024 16:08
@mitsudome-r mitsudome-r marked this pull request as ready for review December 16, 2024 08:44
@mitsudome-r mitsudome-r force-pushed the add-autoware-component-interface-specs branch from 6129660 to fb905d6 Compare December 16, 2024 13:20
@mitsudome-r mitsudome-r added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 35.53719% with 78 lines in your changes missing coverage. Please review.

Project coverage is 35.53%. Comparing base (4cb18f5) to head (4e8661d).
Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
...re_component_interface_specs/test/test_vehicle.cpp 29.41% 0 Missing and 24 partials ⚠️
...toware_component_interface_specs/test/test_map.cpp 30.76% 0 Missing and 18 partials ⚠️
...mponent_interface_specs/test/test_localization.cpp 33.33% 0 Missing and 12 partials ⚠️
...e_component_interface_specs/test/test_planning.cpp 33.33% 0 Missing and 12 partials ⚠️
...re_component_interface_specs/test/test_control.cpp 40.00% 0 Missing and 6 partials ⚠️
...component_interface_specs/test/test_perception.cpp 40.00% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #124       +/-   ##
===========================================
- Coverage   78.75%   35.53%   -43.22%     
===========================================
  Files          11        8        -3     
  Lines         193      121       -72     
  Branches       73       78        +5     
===========================================
- Hits          152       43      -109     
+ Misses         11        0       -11     
- Partials       30       78       +48     
Flag Coverage Δ
differential 35.53% <35.53%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xmfcx
Copy link
Contributor

xmfcx commented Feb 17, 2025

@isamu-takagi -san, could you review this again? @mitsudome-r -san has made the changes you've requested.

@xmfcx xmfcx requested a review from isamu-takagi February 17, 2025 02:15
Copy link

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r force-pushed the add-autoware-component-interface-specs branch from 043adec to 4e8661d Compare February 18, 2025 06:07
@mitsudome-r mitsudome-r enabled auto-merge (squash) February 18, 2025 06:07
@mitsudome-r mitsudome-r merged commit 3a595e4 into autowarefoundation:main Feb 18, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants