Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test-differential): fix fetch depth #55

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 17, 2024

Description

Similar to:

https://github.com/autowarefoundation/autoware.universe/blob/82a10de1f7b49eeeb80108ea3aa6a477d79220f5/.github/workflows/build-and-test-differential.yaml#L39-L46

It will fetch the PR commits for the modified files workflow to function.

For mor details, see:

Related links

Fixes:

image

Tests performed

image

It passes.

This is not a good test since this is only a single commit and there are no modified packages.

But this is used like this in Universe repository and tested extensively there.

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx added the bug Something isn't working label Jun 17, 2024
@xmfcx xmfcx requested a review from kosuke55 June 17, 2024 19:07
@xmfcx xmfcx self-assigned this Jun 17, 2024
@xmfcx
Copy link
Contributor Author

xmfcx commented Jun 17, 2024

I've added all the necessary information to explain how this will fix the issue. Since I've worked on this CI issue a lot and also I caused the issue, I will merge right away and rebase some other PRs to make sure people are not blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant