-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: MetaDrive in ga #30775
CI: MetaDrive in ga #30775
Conversation
Nice! It engaged but I'm curious about the FPS from the sim. We can disable the UI since that will take quite a bit of CPU to software render.
|
@jnewb1 Yeah, seems run better with the ui blocked |
The idea is to replicate the test_onroad coverage both in GitHub Actions and in the simulator, so we don't want to start turning things off. Can we make the UI run nicely during the test? Is that the only thing that lags here? |
@adeebshihadeh From my tests it seem to only be the ui lagging and soundd crashing. Do we want the ui running above 15 fps? |
Yes, we want to run the full stack. Does soundd crash consistently or intermittently? |
soundd is crashing because there is no sound device to connect to, we will just have to add a virtual sound card or something |
Closing due to no activity, feel free to reopen if you pick it back up. |
It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template. |
This reverts commit 7686d2c.
For #30693
Succeed 10 times in a row, will do more testing.