Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: MetaDrive in ga #30775

Closed
wants to merge 25 commits into from

Conversation

maxime-desroches
Copy link
Contributor

@maxime-desroches maxime-desroches commented Dec 17, 2023

For #30693

Succeed 10 times in a row, will do more testing.

@jnewb1
Copy link
Contributor

jnewb1 commented Dec 17, 2023

Nice! It engaged but I'm curious about the FPS from the sim. We can disable the UI since that will take quite a bit of CPU to software render.

selfdrive/ui/qt/onroad.cc: slow frame rate: 5.79 fps

@maxime-desroches
Copy link
Contributor Author

@jnewb1 Yeah, seems run better with the ui blocked

@adeebshihadeh
Copy link
Contributor

The idea is to replicate the test_onroad coverage both in GitHub Actions and in the simulator, so we don't want to start turning things off. Can we make the UI run nicely during the test? Is that the only thing that lags here?

@maxime-desroches
Copy link
Contributor Author

@adeebshihadeh From my tests it seem to only be the ui lagging and soundd crashing. Do we want the ui running above 15 fps?

@adeebshihadeh
Copy link
Contributor

Yes, we want to run the full stack. Does soundd crash consistently or intermittently?

@jnewb1
Copy link
Contributor

jnewb1 commented Dec 18, 2023

soundd is crashing because there is no sound device to connect to, we will just have to add a virtual sound card or something

@jnewb1 jnewb1 linked an issue Dec 20, 2023 that may be closed by this pull request
@jnewb1 jnewb1 linked an issue Dec 20, 2023 that may be closed by this pull request
@adeebshihadeh
Copy link
Contributor

Closing due to no activity, feel free to reopen if you pick it back up.

@jnewb1 jnewb1 reopened this Jan 23, 2024
Copy link
Contributor

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

@jnewb1 jnewb1 marked this pull request as ready for review January 23, 2024 17:39
@jnewb1 jnewb1 marked this pull request as draft January 23, 2024 17:39
@jnewb1 jnewb1 mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run MetaDrive simulation test in GitHub Actions
3 participants