Replace launcha with adminer command

[mejta]

The Issue

The current way to launch Adminer is via ddev launcha -a. It's different from how e.g. PHPMyAdmin is launched (ddev phpmyadmin).

How This PR Solves The Issue

PR changes launching the Adminer the same way like PHPMyAdmin:
ddev adminer

Manual Testing Instructions

ddev get https://github.com/mejta/ddev-adminer/tarball/replace-launcha-with-adminer-command

[rfay]

Test this one with

ddev get https://github.com/mejta/ddev-adminer/tarball/replace-launcha-with-adminer-command

[rfay]

I think this is the way to go, and thanks!

Right now, it gives the required message on ddev launcha -h:

Launcha is no longer available. Please use 'ddev launch' instead. To run Adminer, please use 'ddev adminer'.

BUT... it doesn't give that message when people use ddev launcha, which just silently returns. Please make it return with error text and an error exit value, thanks!

Improving the test would be good too, currently it has

  ddev help adminer | grep adminer >/dev/null
  ddev help launcha | grep adminer >/dev/null

but really testing for ddev launcha returning an error would be better.

[tyler36]

Confirmed.

$ ddev launcha -h                                                                            
Launcha is no longer available. Please use 'ddev launch' instead. To run Adminer, please use 'ddev adminer'.
Failed to run launcha -h; error=exit status 2

ddev launcha appears to do nothing:

$ ddev launcha

$

[mejta]

@rfay I've updated the code. I'm not super-confident with bash, so I've created a test that fails if the exit status on ddev launcha is 0, so hopefully, it's written well :) Thank you for your comments and for maintaining DDEV; it's a super-useful tool!

[rfay]

Sorry, I should have mentioned this simpler approach before, and wasn't clear.

Just make the launcha command look something like this:

#!/bin/bash
#ddev-generated
printf "'ddev launcha' is no longer available. Use 'ddev launch' and 'ddev adminer' instead."
exit 2

Maybe give a link to https://github.com/ddev-ddev-adminer.

[rfay]

I don't want to lose track of this; can you try the super-simple approach? thanks @mejta !

[rfay]

This also resolves

• DDEV_MAILHOG_PORT and friends replaced by DDEV_MAILPIT_HTTP_PORT and DDEV_MAILPIT_HTTPS_PORT #19

Yay!

[mejta]

Sorry for delay, launcha command modified.