-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export palette as a JSON #5
Conversation
Thanks @ziyafenn ! I'll look closer later today. Playing with it in the browser, I'm wondering if it's possible to control focus a little bit, for example when the dialog opens place focus on the close span, and when it closes, place focus back on export palette button. If that's relatively simple I'd love to try to get that in there. I'll check the code shortly. |
This looks all good @ziyafenn. Let me know if you're interested in trying to get the focus a bit more standard as mentioned above. Otherwise I'll likely merge this and make a new issue. |
hey @edelstone. Here is the article from developers.google about focus and tabindex. I will try now implement the modal in a way, that once it is displayed, first |
I pushed a commit that fixes those issues:
PS. |
Hi @ziyafenn . Thanks for the update, and the overall work. |
Created a function to export palettes as a JSON
Code can be further refactored to reduce the repeats in code. I don't have enough time right now to make it better, probably sometime later.
For time being, it gets its job done.
Also added modal and button components.
#4