refactor(eslint-plugin-react-hooks): change array type and improve conditionals #32400
+97
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds configuration to the eslint config governing `eslint-plugin-react-hooks` to use the typescript-eslint plugin and parser. It adds the typescript-recommended config, and configures the team's preferred `array-type` convention.
This change addresses several feedback items from facebook#32240
michaelfaith
force-pushed
the
build/add-typescript-eslint-to-eslint-plugin
branch
from
540d0d9 to
a3279f4
Compare
|
Comparing: eb1f77d...9913a7b Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
michaelfaith
commented
Feb 16, 2025
poteto
reviewed
Feb 16, 2025
| @@ -40,11 +40,11 @@ jobs: | |||
| uses: actions/cache@v4 | |||
| id: node_modules | |||
| with: | |||
| path: "**/node_modules" | |||
| path: "node_modules" | |||
There was a problem hiding this comment.
Was this just to bust the cache? I don't see why what it was previously needs to be changed
There was a problem hiding this comment.
The node_modules within the fixtures are soft-linking to the build directory for the eslint-plugin. When those node_modules were fulfilled from cache, the symlinks were broken, and after the build, it's not re-linked. So this changes it so that it's still caching the root node_modules, but not the nested ones. That way those node_modules with the symlinks can be created each time.
michaelfaith
force-pushed
the
build/add-typescript-eslint-to-eslint-plugin
branch
from
a3279f4 to
ff47b9e
Compare
This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens. ci (eslint-e2e): exclude nested `node_modules` from cache This change removes the nested fixture node_modules from being cached, so that the symbolic link can be made after the build happens.
michaelfaith
force-pushed
the
build/add-typescript-eslint-to-eslint-plugin
branch
from
ff47b9e to
6ea4c0d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
…nditionals (#32400) - [build(eslint-plugin-react-hooks): add ts-linting](4c0fbe7) This change adds configuration to the eslint config governing `eslint-plugin-react-hooks` to use the typescript-eslint plugin and parser. It adds the typescript-recommended config, and configures the team's preferred `array-type` convention. - [refactor(eslint-plugin-react-hooks): improve conditionals](540d0d9) This change addresses several feedback items from #32240 - [ci (eslint-e2e): exclude nested node_modules from cache](a3279f4) This change removes the nested fixture `node_modules` from being cached, so that the symbolic link can be made after the build happens. DiffTrain build for [4632e36](4632e36)
michaelfaith
deleted the
build/add-typescript-eslint-to-eslint-plugin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build(eslint-plugin-react-hooks): add ts-linting
This change adds configuration to the eslint config governing
eslint-plugin-react-hooksto use the typescript-eslint plugin and parser. It adds the typescript-recommended config, and configures the team's preferredarray-typeconvention.refactor(eslint-plugin-react-hooks): improve conditionals
This change addresses several feedback items from feat(eslint-plugin-react-hooks): convert to typescript and package type declarations #32240
ci (eslint-e2e): exclude nested node_modules from cache
This change removes the nested fixture
node_modulesfrom being cached, so that the symbolic link can be made after the build happens.