bug: Fix memory leakage cause by permanent storage of decoded video frame and not closed video stream #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilookas
changed the title
hilookas
changed the title
hilookas
force-pushed
the
fix_memory_leakage
branch
from
3c904d0 to
6d5db64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
load_from_videoswill storage decoded image to internalself.hf_datasetarray, which will cause memory leakage specifically with large size of image.lerobot/lerobot/common/datasets/lerobot_dataset.py
Line 136 in 97086cd
Besides that, PyAV has a bug, which will cause memory leak when stream is not properly closed.
See: PyAV-Org/PyAV#1117
How to checkout & try? (for the reviewer)
Provide a simple way for the reviewer to try out your changes.
Examples:
htop # sorry, but memory leakage issue is hard to write a test...