Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conform pyproject to PEP 621 #621

Merged
merged 4 commits into from
Feb 16, 2025

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Jan 8, 2025

What this does

⚠️ DO NOT MERGE YET
Poetry 2.0.0 seems to have performance issues when solving dependencies.
Generating this new poetry.lock file took more than 17mn (1038.1s)
Using the --regenerate option, this was even worse as I had to killed it after 47mn (it hadn't finished)

Resolved with poetry 2.1.0

This standardizes the pyproject.toml to conform exactly to PEP 621 as it's now possible to do with poetry 2 which just released.

Users of poetry will need to update their version of poetry.

If you installed poetry with the installer script:

poetry self update

If you installed poetry using pipx:

pipx upgrade poetry

Note that the commands changed slightly, here are the equivalent for the most common ones:

# install all extras
- poetry install --sync --all-extras
+ poetry sync --all-extras

# update lock file from pyproject.toml with no version upgrade in lock file
- poetry lock --no-update
+ poetry lock

# update lock file from pyproject.toml with versions upgrade in lock file
- poetry lock
+ poetry lock --regenerate

More details in the release notes

How it was tested

Project still installs correctly, no regression observed with poetry 2.1.0

@aliberts aliberts added the ➡️ Dependencies Adding, removing or updating dependencies label Jan 8, 2025
@aliberts aliberts mentioned this pull request Jan 8, 2025
@aliberts aliberts self-assigned this Jan 8, 2025
@aliberts aliberts changed the title Migrate to poetry 2.0.0 Conform pyproject to PEP 621 Feb 7, 2025
@aliberts aliberts marked this pull request as ready for review February 15, 2025 19:38
@aliberts aliberts merged commit ddeade0 into main Feb 16, 2025
7 checks passed
@aliberts aliberts deleted the user/aliberts/2025_01_08_update_to_poetry_2 branch February 16, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
➡️ Dependencies Adding, removing or updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants