Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Topic/acceleration constraints #28

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ahundt
Copy link

@ahundt ahundt commented Apr 26, 2017

#27

These changes are on top of the alignment fixes.

@haudren
Copy link
Collaborator

haudren commented Apr 26, 2017

Thanks for this PR!

I understand better what you want to do now 😼 I had also worked on something similar to limit the CoM acceleration for our humanoid robot. As we are interested in making Tasks better, I would rather like to have a generic bounds constraint, that will allow to share the adding/removing/updating mechanics at least.

In the very end, I'd like all the "bounds" constraint to share most of the computing logic. Ideally, they should only differ by the dimension and the way we compute the Jacobian.

Additionally, it would be nice if it would be generic for directions i.e. instead of enforcing:

l  <= J qdd + Jd qd <= u

Enforcing for every direction n:

l <= (J qdd + Jd qd).dot(n) <= u

I will maybe see with @gergondet and @aescande if it's better to accept this PR as is or wait for some refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants