Add missing target dependencies to eigen_stl_containers #3295
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sea-bass
requested review from
mikeferguson,
henningkayser,
rhaschke,
JafarAbdi and
sjahr
sea-bass
added
backport-humble
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3295 +/- ##
==========================================
- Coverage 45.58% 45.57% -0.00%
==========================================
Files 716 716
Lines 62383 62383
Branches 7545 7545
==========================================
- Hits 28428 28422 -6
- Misses 33790 33795 +5
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. |
mikeferguson
approved these changes
Feb 1, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2025
* Add missing target dependencies to eigen_stl_containers * Another one (cherry picked from commit d88d19f) # Conflicts: # moveit_core/collision_detection/CMakeLists.txt # moveit_core/robot_state/CMakeLists.txt
mergify bot
pushed a commit
that referenced
this pull request
Feb 1, 2025
* Add missing target dependencies to eigen_stl_containers * Another one (cherry picked from commit d88d19f)
This was referenced Feb 1, 2025
sea-bass
added a commit
that referenced
this pull request
Feb 1, 2025
(cherry picked from commit d88d19f) Co-authored-by: Sebastian Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was doing a "build on potato computer" build of MoveIt 2 with
-j 4and--executor sequential, and found myself with some errors related to missingeigen_stl_containersheaders.Turns out there has been a missing target dependency in these targets that use the library? Not sure how others haven't run into this, or whether some upstream dependency recently removed this transitively?
Checklist