Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Accuracy, Drain Time, Play Time, Spectate stubs #3153

Merged
merged 16 commits into from
Mar 22, 2020
Merged

Add Accuracy, Drain Time, Play Time, Spectate stubs #3153

merged 16 commits into from
Mar 22, 2020

Conversation

Pennek
Copy link
Contributor

@Pennek Pennek commented Feb 3, 2020 •
edited
Loading

Resolves part of #3149

cl8n
cl8n requested changes Feb 4, 2020
View reviewed changes
Copy link
Member

@cl8n cl8n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all four of these have Glossary entries, Accuracy has /Accuracy and Spectate has /Replay#spectator.

i guess this is the kind of thing we have to figure out how to handle

@Loctav Loctav mentioned this pull request Feb 4, 2020
Closed
35 tasks
MegaApplePi
MegaApplePi requested changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@MegaApplePi MegaApplePi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

folder names need to be fixed:

  • wiki/Gameplay/Drain Time/en.md needs to be wiki/Gameplay/Drain_time/en.md
  • wiki/Gameplay/Play Time/en.md needs to be wiki/Gameplay/Play_time/en.md

spaces need to be replaced with underscores

wiki/Gameplay/Drain Time/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Play Time/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Spectate/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/en.md Outdated Show resolved Hide resolved
@Pennek Pennek requested a review from MegaApplePi February 8, 2020 01:12
MegaApplePi
MegaApplePi requested changes Feb 8, 2020
View reviewed changes
wiki/Gameplay/Play_time/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Play_time/en.md Show resolved Hide resolved
wiki/Gameplay/Spectate/en.md Show resolved Hide resolved
wiki/Gameplay/Drain_time/en.md Show resolved Hide resolved
wiki/Gameplay/Drain_time/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Drain_time/en.md Outdated Show resolved Hide resolved
@MegaApplePi
Copy link
Contributor

I think the accuracy stub reads weirdly.. I'm going to sleep on it before trying to make suggestions unless someone else gets to it.

@Pennek
Copy link
Contributor Author

Pennek commented Feb 8, 2020

had to force push to correct my master branch not being in sync with ppy/master

@MegaApplePi MegaApplePi self-requested a review February 9, 2020 03:35
MegaApplePi
MegaApplePi requested changes Feb 14, 2020
View reviewed changes
wiki/Gameplay/Accuracy/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Accuracy/en.md Show resolved Hide resolved
wiki/Gameplay/Spectate/en.md Outdated Show resolved Hide resolved
wiki/Gameplay/Spectate/en.md Outdated Show resolved Hide resolved
Pennek and others added 4 commits February 17, 2020 23:20
@Pennek @MegaApplePi
tag
15d8f51 
Co-Authored-By: Eric X <[email protected]>
@Pennek @MegaApplePi
tagg
0568508 
Co-Authored-By: Eric X <[email protected]>
@Pennek @MegaApplePi
more tags
5d0cf40 
Co-Authored-By: Eric X <[email protected]>
@Pennek
change wording of accuracy
f016b33
MegaApplePi
MegaApplePi previously approved these changes Feb 22, 2020
View reviewed changes
@MegaApplePi MegaApplePi requested a review from cl8n February 22, 2020 02:01
@cl8n cl8n merged commit 75bb704 into ppy:master Mar 22, 2020
@Pennek Pennek deleted the gameplay-stubs branch July 4, 2020 23:10
@Pennek Pennek mentioned this pull request Jul 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl8n cl8n cl8n approved these changes

@MegaApplePi MegaApplePi MegaApplePi left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pennek @MegaApplePi @cl8n @TPGPL