Setting new ip to etcd member #161
Merged
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tsorya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
omertuc
requested changes
Sep 12, 2024
tsorya
force-pushed
the
igal/ip_etcd_rename
branch
2 times, most recently
from
7afc9cf to
d346917
Compare
tsorya
commented
Sep 12, 2024
omertuc
reviewed
Sep 12, 2024
tsorya
force-pushed
the
igal/ip_etcd_rename
branch
from
d346917 to
248da0e
Compare
tsorya
force-pushed
the
igal/ip_etcd_rename
branch
from
248da0e to
35cfc40
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit fbe7f39
into
rh-ecosystem-edge:main
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements logic from lca https://github.com/openshift-kni/lifecycle-agent/blob/main/lca-cli/postpivot/postpivot.go#L358
As we moved all the ip change logic into recert we should handle this part here too.
This code updates existing member with new ip