-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zc - Code Size Reduction chapter integration. #1216
Conversation
Added the zc.adoc spec to the src tree.
Add zc include to unpriv.
Pulling in the Zc chapter.
Moved Zc chapter to land after tso chapter. Started cleaning up asciidoc.
Added another equal sign to the heading level to set it correctly.
Added another equal sign to the header to make it at the correct level.
Adjusted heading levels to fit into overall document. Changed Notes to the standard within the overall document.
Replaced all of the included content with it's actual content. Reformatted text to match rest of spec. Move zc.adoc to src file with all other chapters.
Removing Zc chapter folder as all content is now in 1 file, zc.adoc.
Fixing formatting of rs1' text.
As this spec is ratified, the word proposed no longer applies.
Hi - how can I get the unpriv PDF? The artefacts don't seem to be kept? |
I think I'd remove the version history but otherwise it looks good, except for the missing xrefs which should probably be removed |
You can always click on Actions, then on the left click RISC-V ISA Build, then on the right Run workflow dropdown, then change the Branch to Zc and click run workflow. You'll see the workflow begin to run, once it's done, click on it and you'll see the artifacts. |
I removed the version history yesterday. I'll remove the xrefs today. |
Co-authored-by: sorear <[email protected]> Signed-off-by: Bill Traynor <[email protected]>
Co-authored-by: sorear <[email protected]> Signed-off-by: Bill Traynor <[email protected]>
Commented out the 32-bit equivalent instructions that are not present yet and therefore are broken links.
Comment out 32-bit instruction with broken link.
@tariqkurd-repo I've commented out the 32-bit instruction sections with broken links. Should those instructions get added, these sections can be restored. Let me know if we're good to merge this chapter now. Note that when I merge it, I will archive the original Zc repository. |
Fix broken link to PPO Rule 11.
Thanks Bill, I'll have a look in the morning. |
Hi Bill - can you send me a pdf to review? I can't build it until I get my asciidoctor isntallation fixed, which I can't do right now. However - are the encodings now in the overall table of 16-bit encodings - or will that come later? |
Sure, here's the PDF., Zc is Chapter 28. Anything content specific is up
to the original author(s) to add to the spec, which can be done post
merge. Phase 1 of the merge strategy is to merge the ratified specs as is.
…On Tue, Feb 27, 2024 at 8:12 AM Tariq Kurd ***@***.***> wrote:
Hi Bill - can you send me a pdf to review? I can't build it until I get my
asciidoctor isntallation fixed, which I can't do right now. However - are
the encodings now in the overall table of 16-bit encodings - or will that
come later?
—
Reply to this email directly, view it on GitHub
<#1216 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN6ZFYEREE4VRLPMYXOS3YVXLTLAVCNFSM6AAAAABC4IXICGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWGUYTQMZRGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I add a few comments, all related to rendering. |
Adding alternate text for xrefs
Fixed xref alternate text etc.
I've updated as per your suggestions. I'll merge this spec today and any future changes can be made against riscv-isa-manual's main branch. |
This PR pull the Zc - Code Size Reduction specification in as a chapter.