Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zc - Code Size Reduction chapter integration. #1216

Merged
merged 19 commits into from
Feb 29, 2024
Merged

Zc - Code Size Reduction chapter integration. #1216

merged 19 commits into from
Feb 29, 2024

Conversation

wmat
Copy link
Collaborator

@wmat wmat commented Feb 6, 2024

This PR pull the Zc - Code Size Reduction specification in as a chapter.

wmat added 7 commits January 31, 2024 10:33
Added the zc.adoc spec to the src tree.
Add zc include to unpriv.
Pulling in the Zc chapter.
Moved Zc chapter to land after tso chapter.
Started cleaning up asciidoc.
Added another equal sign to the heading level to set it correctly.
Added another equal sign to the header to make it at the correct level.
Adjusted heading levels to fit into overall document.
Changed Notes to the standard within the overall document.
@wmat wmat changed the title Zc Zc - Code Size Reduction chapter integration. Feb 6, 2024
src/zc/Zc.adoc Outdated Show resolved Hide resolved
src/zc/Zc.adoc Outdated Show resolved Hide resolved
src/zc/Zc.adoc Outdated Show resolved Hide resolved
src/zc/Zc.adoc Outdated Show resolved Hide resolved
src/zc/Zcmd.adoc Outdated Show resolved Hide resolved
src/zc/c_lbu.adoc Outdated Show resolved Hide resolved
src/zc/example.bib Outdated Show resolved Hide resolved
src/zc/readme.md Outdated Show resolved Hide resolved
wmat added 3 commits February 22, 2024 10:41
Replaced all of the included content with it's actual content.
Reformatted text to match rest of spec.
Move zc.adoc to src file with all other chapters.
Removing Zc chapter folder as all content is now in 1 file, zc.adoc.
Fixing formatting of rs1' text.
As this spec is ratified, the word proposed no longer applies.
@tariqkurd-repo
Copy link
Contributor

Hi - how can I get the unpriv PDF? The artefacts don't seem to be kept?

@tariqkurd-repo
Copy link
Contributor

tariqkurd-repo commented Feb 23, 2024

I think I'd remove the version history but otherwise it looks good, except for the missing xrefs which should probably be removed

@wmat
Copy link
Collaborator Author

wmat commented Feb 23, 2024

Hi - how can I get the unpriv PDF? The artefacts don't seem to be kept?

You can always click on Actions, then on the left click RISC-V ISA Build, then on the right Run workflow dropdown, then change the Branch to Zc and click run workflow. You'll see the workflow begin to run, once it's done, click on it and you'll see the artifacts.

@wmat
Copy link
Collaborator Author

wmat commented Feb 23, 2024

I think I'd remove the version history but otherwise it looks good, except for the missing xrefs which should probably be removed

I removed the version history yesterday. I'll remove the xrefs today.

src/zc.adoc Outdated Show resolved Hide resolved
src/zc.adoc Outdated Show resolved Hide resolved
wmat and others added 4 commits February 26, 2024 07:23
Co-authored-by: sorear <[email protected]>
Signed-off-by: Bill Traynor <[email protected]>
Co-authored-by: sorear <[email protected]>
Signed-off-by: Bill Traynor <[email protected]>
Commented out the 32-bit equivalent instructions that are not present yet
and therefore are broken links.
Comment out 32-bit instruction with broken link.
@wmat
Copy link
Collaborator Author

wmat commented Feb 26, 2024

@tariqkurd-repo I've commented out the 32-bit instruction sections with broken links. Should those instructions get added, these sections can be restored.

Let me know if we're good to merge this chapter now. Note that when I merge it, I will archive the original Zc repository.

Fix broken link to PPO Rule 11.
@tariqkurd-repo
Copy link
Contributor

Thanks Bill, I'll have a look in the morning.

@tariqkurd-repo
Copy link
Contributor

Hi Bill - can you send me a pdf to review? I can't build it until I get my asciidoctor isntallation fixed, which I can't do right now. However - are the encodings now in the overall table of 16-bit encodings - or will that come later?

@wmat
Copy link
Collaborator Author

wmat commented Feb 27, 2024 via email

src/zc.adoc Outdated Show resolved Hide resolved
@tariqkurd-repo
Copy link
Contributor

I add a few comments, all related to rendering.
The main one is that every xref to e.g. "The <> extension" renders as "The Section 28.x extension" which isn't as expected.

wmat added 2 commits February 29, 2024 10:08
Adding alternate text for xrefs
Fixed xref alternate text etc.
@wmat
Copy link
Collaborator Author

wmat commented Feb 29, 2024

I've updated as per your suggestions. I'll merge this spec today and any future changes can be made against riscv-isa-manual's main branch.

@wmat wmat merged commit c9ad1c8 into main Feb 29, 2024
2 checks passed
@wmat wmat deleted the zc branch February 29, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants