Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and submit a report for approval #135

Closed
6 of 12 tasks
pamlo412 opened this issue Nov 6, 2020 · 3 comments · Fixed by #264
Closed
6 of 12 tasks

Review and submit a report for approval #135

pamlo412 opened this issue Nov 6, 2020 · 3 comments · Fixed by #264
Assignees
Labels
8 Story Points enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Milestone

Comments

@pamlo412
Copy link
Contributor

pamlo412 commented Nov 6, 2020

User story:
As a Regional TTA Specialist who has completed anActivity Report, I want to submit it for approval to my approving manager.

Acceptance criteria:

  • users can't submit until all required fields are completed (See note in Comments, 11/17)
    • if a user tries to submit before all required fields are completed, a validation error message displays
  • user can use the menu to navigate through the report sections to review before clicking submit
    • if all required fields are not completed, a validation error message displays
  • the report's creator and any others assigned as collaborators (see Add collaborators to draft Activity Reports #109) can select one manager to approve.
  • the system prefilters the selectable managers to those users who have permissions to this region and one of the following roles:
    • TTAC
    • Early Childhood Manager
    • Grantee Specialist Manager
  • the report's status changes on submission to "Submitted for approval"
  • the author and all collaborators on a report can submit the report for approval
  • the report remains open for editing (author and collaborators only) on submission

Design:
https://preview.uxpin.com/ad995fd722bd26c0f9a1c8a115f1b41833637308#/pages/133997819/simulate/no-panels

Exclusions:

@pamlo412 pamlo412 added enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue labels Nov 6, 2020
@pamlo412 pamlo412 changed the title Submitting a report for approval Review and submit a report for approval Nov 9, 2020
@PatricePascual-ACF
Copy link
Contributor

Hi, @pamlo412. I don't think this is ready for grooming, unfortunately.
Damon, Aricka and I need to review the list of required fields. We have not had that discussion (11/17).

@pamlo412
Copy link
Contributor Author

pamlo412 commented Nov 17, 2020

Per discussion with @PatricePascual-ACF at grooming, we will handle the validations via a different story, #158. We have a meeting scheduled for Nov 19 to flesh out that story.

@kryswisnaskas - we need you and the devs to point this one.

@pamlo412
Copy link
Contributor Author

pamlo412 commented Dec 7, 2020

@jasalisbury : In Product Planning today, we broached the possibility that we don't want to allow the user to enter multiple managers as approvers. @PatricePascual-ACF will be discussing this issue with Damon soon. I'm noting it here because this is the story with the multiple approvals requirement.
@jasalisbury: we are keeping multiple managers. Thanks!

rahearn added a commit that referenced this issue Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 Story Points enhancement New feature or request In epic 5 Issue is a child in the indicated parent epic V1.0 MVP Indicates the release version for the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants