Additional @icon checks
#1303
Merged
Additional @icon checks
#1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug fix on helper * Automate rejection of an occasional issue with excessive dimensions Post OpenUserJS#1283 OpenUserJS#1274
Martii
added
bug
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 5, 2017
* Accommodate some higher DPI monitors Post OpenUserJS#1303
Martii
added a commit
that referenced
this pull request
Dec 5, 2017
* Accommodate some higher DPI monitors Post #1303 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 5, 2017
* Consolidate test into an inline function for reuse * Check detected types and reject the rest... may add to later NOTES: * This is as much as I prefer to go *(may change)*... otherwise the user experience on OUJS will be diminished by excessive bandwidth from client to whatever target. * Ideally these shouldn't be more than 48px by 48px if an author is being nice to their users as well as visitors but do understand some hosting sites kick it up a bit without scaling. Post OpenUserJS#1303
Martii
added a commit
that referenced
this pull request
Dec 5, 2017
* Consolidate test into an inline function for reuse * Check detected types and reject the rest... may add to later NOTES: * This is as much as I prefer to go *(may change)*... otherwise the user experience on OUJS will be diminished by excessive bandwidth from client to whatever target. * Ideally these shouldn't be more than 48px by 48px if an author is being nice to their users as well as visitors but do understand some hosting sites kick it up a bit without scaling. Post #1303 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 5, 2017
* Should speeds things up a bit for I/O Post OpenUserJS#1303
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 5, 2017
Martii
added a commit
that referenced
this pull request
Dec 5, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 9, 2018
* Apparently there is a long standing issue with EPROTO and this. Will need to dive in way deep and wait until it is fixed. * Project error trapping yielded no results * Altered to use *request* and same issue as denoted on the issue * Prevents the server trip from *node* builtin and other mentioned package. Applies to OpenUserJS#1323 and post OpenUserJS#1303
Martii
added a commit
that referenced
this pull request
Feb 9, 2018
#1324) * Apparently there is a long standing issue with EPROTO and this. Will need to dive in way deep and wait until it is fixed. * Project error trapping yielded no results * Altered to use *request* and same issue as denoted on the issue * Prevents the server trip from *node* builtin and other mentioned package. Applies to #1323 and post #1303 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 10, 2018
* Prevents a server trip on malformed value or missing target with no data with: * Double check that dimensions exist in case the dep fails ``` sh-session RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ERR_INDEX_OUT_OF_RANGE ``` Post OpenUserJS#1303
Martii
added a commit
that referenced
this pull request
Feb 10, 2018
* Double check that dimensions exist in case the dep fails * Prevents a server trip on malformed value or missing target with no data with: ``` sh-session RangeError [ERR_HTTP_INVALID_STATUS_CODE]: Invalid status code: ERR_INDEX_OUT_OF_RANGE ``` Post #1303 and very loosely related to #1323 Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Feb 23, 2018
* Covers redirection automatically * Fix undocumented type of `jpg` for `jpeg` *(my gravatar for example)* * Left a response handler in there because **undoubtedly** there's going to be an issue cropping up with something in that arena * Found an inline dependency to deal with later when more time available... added TODO * `Buffer` method utilized is deprecated for base64 will affect repoManager... more TODO later NOTE: * I'm extremely short on time at the moment so thanks to everyone helping out with issues Post OpenUserJS#1303 and should close OpenUserJS#1331
Martii
added a commit
that referenced
this pull request
Feb 23, 2018
* Covers redirection automatically * Fix undocumented type of `jpg` for `jpeg` *(my gravatar for example)* * Left a response handler in there because **undoubtedly** there's going to be an issue cropping up with something in that arena * Found an inline dependency to deal with later when more time available... added TODO * `Buffer` method utilized is deprecated for base64 will affect repoManager... more TODO later NOTE: * I'm extremely short on time at the moment so thanks to everyone helping out with issues Post #1303 and should close #1331 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post #1283 #1274