Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sampling_based_planner)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in sampling_based_planner #9916

Merged

Conversation

vish0012
Copy link
Contributor

…es planning/sampling_based_planner

Description

The tier4_debug_msgs have been replaced with autoware_internal_debug_msgs to enhance clarity and consistency in the codebase.

Related links

autowarefoundation/autoware#5580

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@vish0012 vish0012 requested a review from maxime-clem as a code owner January 15, 2025 00:25
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 15, 2025
Copy link

github-actions bot commented Jan 15, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2025
…es planning/sampling_based_planner

Signed-off-by: vish0012 <[email protected]>
@takayuki5168 takayuki5168 force-pushed the replace_debug_msgs_based_planner branch from 6ff6e21 to efbb763 Compare January 17, 2025 07:38
@takayuki5168
Copy link
Contributor

@vish0012
The build CI failed. Please have a check.

@mitsudome-r mitsudome-r changed the title feat: tier4_debug_msgs changed to autoware_internal_debug_msgs in fil… feat(sampling_based_planner)!: tier4_debug_msgs changed to autoware_internal_debug_msgs in sampling_based_planner Jan 17, 2025
@mitsudome-r
Copy link
Member

@vish0012 I think you have to also modify the following lines:

deleted duplicate
Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.12%. Comparing base (74f6779) to head (80e6e00).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9916      +/-   ##
==========================================
- Coverage   29.13%   29.12%   -0.01%     
==========================================
  Files        1425     1426       +1     
  Lines      107845   107857      +12     
  Branches    42249    42247       -2     
==========================================
+ Hits        31416    31417       +1     
- Misses      73386    73398      +12     
+ Partials     3043     3042       -1     
Flag Coverage Δ *Carryforward flag
differential 23.91% <ø> (?)
total 29.13% <ø> (+<0.01%) ⬆️ Carriedforward from 74f6779

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 3138d75 into autowarefoundation:main Jan 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants