Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating load/store pair for RV32 with the main manual #1767

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Integrating load/store pair for RV32 with the main manual #1767

wants to merge 5 commits into from

Conversation

christian-herber-nxp
Copy link

to be merged post ratification. posted here for early review

@christian-herber-nxp christian-herber-nxp linked an issue Dec 11, 2024 that may be closed by this pull request
Integrate Load/Store Pair for RV32 #1766
Open
wmat
wmat reviewed Dec 11, 2024
View reviewed changes
src/zfinx.adoc Outdated Show resolved Hide resolved
wmat
wmat reviewed Dec 11, 2024
View reviewed changes
src/zilsd.adoc Outdated Show resolved Hide resolved
wmat
wmat requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@wmat wmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for the 2 comments I added.

@wmat
Copy link
Collaborator

wmat commented Dec 11, 2024

Thanks, I will leave merging to @aswaterman

@christian-herber-nxp
Copy link
Author

Please also check the changes i just did on colophon.adoc.
I realized that this definitely has to be added.
I am not sure I did this as it is expected.
Not even sure it is correct as it is now.

@wmat
Copy link
Collaborator

wmat commented Dec 11, 2024

colophon changes look correct to me.

aswaterman
aswaterman reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with me once @wmat thinks it's ready.

aswaterman
aswaterman requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, let's not merge until the board votes to ratify, as we are in the process of trying to release a new set of ratified-only specs.

@wmat
Copy link
Collaborator

wmat commented Dec 16, 2024

Please don't merge until the BoD has ratified, thanks.

@rpsene rpsene added the Ratification Pending At Ratification-Ready, pending approval. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswaterman aswaterman aswaterman requested changes

@wmat wmat wmat requested changes

Assignees
No one assigned
Labels
Ratification Pending At Ratification-Ready, pending approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate Load/Store Pair for RV32
4 participants
@christian-herber-nxp @wmat @aswaterman @rpsene