Gen random circle point from channel #170
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson)
stwo_cairo_verifier/src/circle.cairo line 112 at r1 (raw file):
#[generate_trait] pub impl CirclePointQM31AddCirclePointM31Impl of CirclePointQM31AddCirclePointM31Trait {
should we add a test for that?
Code quote:
pub impl CirclePointQM31AddCirclePointM31Impl of CirclePointQM31AddCirclePointM31Trait {
andrewmilson
force-pushed
the
11-14-Gen_random_circle_point_from_channel
branch
from
2b7ff04
to
bdf91e2
Compare
andrewmilson
force-pushed
the
11-14-Gen_random_circle_point_from_channel
branch
from
bdf91e2
to
9dbf239
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
stwo_cairo_verifier/src/circle.cairo line 112 at r1 (raw file):
Previously, shaharsamocha7 wrote…
should we add a test for that?
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)
This change is