-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add README for cairo verifier #153
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fe6591b
to
e2b4e58
Compare
c7df8ae
to
ed8c5fc
Compare
e2b4e58
to
64142f7
Compare
ed8c5fc
to
edfd78b
Compare
64142f7
to
bf16ace
Compare
edfd78b
to
7b2e167
Compare
bf16ace
to
a9ad4a6
Compare
install scarb? |
install? Code quote: Modify [`Scarb.toml`](./Scarb.toml) to use [Starknet Foundary](https://github.com/foundry-rs/starknet-foundry). |
7b2e167
to
e348657
Compare
a9ad4a6
to
44ffaa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
stwo_cairo_verifier/README.md
line 7 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
install scarb?
Done.
stwo_cairo_verifier/README.md
line 15 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
install?
Should be handled by the asdf install
command.
It installs everything in .tool-versions
e348657
to
c229d88
Compare
44ffaa7
to
a380bdb
Compare
a380bdb
to
80baa7c
Compare
91d7709
to
c6144cb
Compare
Previously, andrewmilson (Andrew Milson) wrote…
You need to do it from the stwo_cairo_verifier folder right? |
Previously, ilyalesokhin-starkware wrote…
I get: |
Previously, ilyalesokhin-starkware wrote…
I seems that I need to do: |
ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ scarb test -- --save-trace-data Code quote: scarb test -- --save-trace-data |
c6144cb
to
e845f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)
stwo_cairo_verifier/README.md
line 15 at r1 (raw file):
Previously, ilyalesokhin-starkware wrote…
I seems that I need to do:
asdf plugin add scarb
asdf plugin add starknet-foundry
Done. Thanks.
stwo_cairo_verifier/README.md
line 33 at r3 (raw file):
Previously, ilyalesokhin-starkware wrote…
ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ scarb test -- --save-trace-data
Running test stwo_cairo_verifier (snforge test --max-n-steps 100000000)
Compiling snforge_scarb_plugin v0.32.0 (git+https://github.com/foundry-rs/starknet-foundry?tag=v0.32.0#3817c903b640201c72e743b9bbe70a97149828a2)
error: packagelalrpop-util v0.20.2
cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p [email protected] --precise ver
wherever
is the latest version oflalrpop-util
supporting rustc 1.67.0
Added TODO to investigate error.
e845f05
to
884c2f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @shaharsamocha7)
This change is