Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README for cairo verifier #153

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Nov 5, 2024

This change is Reviewable

Copy link
Contributor Author

andrewmilson commented Nov 5, 2024

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 7 at r1 (raw file):

## Running tests

[Install asdf](https://asdf-vm.com/guide/getting-started.html#_3-install-asdf).

install scarb?

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 15 at r1 (raw file):

## Visualising test step counts.

Modify [`Scarb.toml`](./Scarb.toml) to use [Starknet Foundary](https://github.com/foundry-rs/starknet-foundry).

install?

Code quote:

Modify [`Scarb.toml`](./Scarb.toml) to use [Starknet Foundary](https://github.com/foundry-rs/starknet-foundry).

Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)


stwo_cairo_verifier/README.md line 7 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

install scarb?

Done.


stwo_cairo_verifier/README.md line 15 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

install?

Should be handled by the asdf install command.
It installs everything in .tool-versions

@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch from 44ffaa7 to a380bdb Compare November 17, 2024 18:09
@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch from a380bdb to 80baa7c Compare November 18, 2024 18:11
@andrewmilson andrewmilson changed the base branch from 10-22-Optimizations to main November 18, 2024 18:11
@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch 2 times, most recently from 91d7709 to c6144cb Compare November 18, 2024 18:24
@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 15 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

Should be handled by the asdf install command.
It installs everything in .tool-versions

You need to do it from the stwo_cairo_verifier folder right?

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 15 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

You need to do it from the stwo_cairo_verifier folder right?

I get:
ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ asdf install
scarb plugin is not installed
starknet-foundry plugin is not installed

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 15 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I get:
ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ asdf install
scarb plugin is not installed
starknet-foundry plugin is not installed

I seems that I need to do:
asdf plugin add scarb
asdf plugin add starknet-foundry

@ilyalesokhin-starkware
Copy link
Collaborator

stwo_cairo_verifier/README.md line 33 at r3 (raw file):

```bash
scarb test -- --save-trace-data

ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ scarb test -- --save-trace-data
Running test stwo_cairo_verifier (snforge test --max-n-steps 100000000)
Compiling snforge_scarb_plugin v0.32.0 (git+https://github.com/foundry-rs/starknet-foundry?tag=v0.32.0#3817c903b640201c72e743b9bbe70a97149828a2)
error: package lalrpop-util v0.20.2 cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p [email protected] --precise ver
where ver is the latest version of lalrpop-util supporting rustc 1.67.0

Code quote:

scarb test -- --save-trace-data

@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch from c6144cb to e845f05 Compare November 19, 2024 14:23
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 6 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @shaharsamocha7)


stwo_cairo_verifier/README.md line 15 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I seems that I need to do:
asdf plugin add scarb
asdf plugin add starknet-foundry

Done. Thanks.


stwo_cairo_verifier/README.md line 33 at r3 (raw file):

Previously, ilyalesokhin-starkware wrote…

ilya@ilya-ThinkPad-T14-Gen-2i:~/workspaces/stwo-cairo/stwo_cairo_verifier$ scarb test -- --save-trace-data
Running test stwo_cairo_verifier (snforge test --max-n-steps 100000000)
Compiling snforge_scarb_plugin v0.32.0 (git+https://github.com/foundry-rs/starknet-foundry?tag=v0.32.0#3817c903b640201c72e743b9bbe70a97149828a2)
error: package lalrpop-util v0.20.2 cannot be built because it requires rustc 1.70 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.70 or newer, or use
cargo update -p [email protected] --precise ver
where ver is the latest version of lalrpop-util supporting rustc 1.67.0

Added TODO to investigate error.

@andrewmilson andrewmilson force-pushed the 11-04-Add_README_for_cairo_verifier branch from e845f05 to 884c2f0 Compare November 19, 2024 14:26
Copy link
Collaborator

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: 1 of 6 files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@andrewmilson andrewmilson merged commit 796c0f2 into main Nov 19, 2024
5 checks passed
@andrewmilson andrewmilson deleted the 11-04-Add_README_for_cairo_verifier branch November 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants