-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor FRI implementation #115
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andrewmilson and the rest of your teammates on Graphite |
accb393
to
b51e6fd
Compare
0bc3f0a
to
1eaef30
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
stwo_cairo_verifier/src/utils.cairo
line 53 at r1 (raw file):
/// Sorts an array in ascending order. Uses quicksort algorithm. fn sort_ascending<+PartialOrd<T>>(self: Array<T>) -> Array<T> {
Doesn't Cairo1 have O(n) sort for PartialOrd
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)
stwo_cairo_verifier/src/utils.cairo
line 53 at r1 (raw file):
Previously, Alon-Ti wrote…
Doesn't Cairo1 have O(n) sort for
PartialOrd
?
Unfortunately not it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
b51e6fd
to
3a5517f
Compare
1eaef30
to
1ce253e
Compare
43a735f
to
99b2a25
Compare
1ce253e
to
69267be
Compare
This change is