Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FRI implementation #115

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Oct 13, 2024

This change is Reviewable

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)


stwo_cairo_verifier/src/utils.cairo line 53 at r1 (raw file):

    /// Sorts an array in ascending order. Uses quicksort algorithm.
    fn sort_ascending<+PartialOrd<T>>(self: Array<T>) -> Array<T> {

Doesn't Cairo1 have O(n) sort for PartialOrd?

Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)


stwo_cairo_verifier/src/utils.cairo line 53 at r1 (raw file):

Previously, Alon-Ti wrote…

Doesn't Cairo1 have O(n) sort for PartialOrd?

Unfortunately not it seems.

@andrewmilson andrewmilson mentioned this pull request Oct 20, 2024
Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@andrewmilson andrewmilson force-pushed the 10-12-Refactor_Coset_with_CirclePointIndex branch from b51e6fd to 3a5517f Compare October 20, 2024 18:06
@andrewmilson andrewmilson force-pushed the 10-13-Refactor_FRI_implementation branch from 1eaef30 to 1ce253e Compare October 20, 2024 18:06
@andrewmilson andrewmilson force-pushed the 10-12-Refactor_Coset_with_CirclePointIndex branch 2 times, most recently from 43a735f to 99b2a25 Compare October 20, 2024 18:20
Base automatically changed from 10-12-Refactor_Coset_with_CirclePointIndex to main October 20, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants