Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unreduced field arithmetic #116

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

andrewmilson
Copy link
Contributor

@andrewmilson andrewmilson commented Oct 14, 2024

Used in downstream PR for computing FRI quotients.


This change is Reviewable

Copy link
Contributor

@Alon-Ti Alon-Ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: up to suggestion once you appease scarb

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)


stwo_cairo_verifier/src/fields/qm31.cairo line 239 at r1 (raw file):

impl UnreducedQM31Mul of Mul<UnreducedQM31> {
    /// Returns `lhs * rhs`. Assumes input coordinates are in the range `[0, P)`.

Maybe there should be a ReducedQM31 type that guarantees this?

@andrewmilson andrewmilson force-pushed the 10-13-Refactor_FRI_implementation branch from 1eaef30 to 1ce253e Compare October 20, 2024 18:06
@andrewmilson andrewmilson force-pushed the 10-13-Add_unreduced_field_arithmetic branch from c901039 to dc18c46 Compare October 20, 2024 18:06
@andrewmilson andrewmilson force-pushed the 10-13-Refactor_FRI_implementation branch from 1ce253e to 69267be Compare October 20, 2024 18:23
Base automatically changed from 10-13-Refactor_FRI_implementation to main October 20, 2024 18:27
@andrewmilson andrewmilson force-pushed the 10-13-Add_unreduced_field_arithmetic branch from dc18c46 to 4f64214 Compare October 20, 2024 22:08
Copy link
Contributor Author

@andrewmilson andrewmilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)


stwo_cairo_verifier/src/fields/qm31.cairo line 239 at r1 (raw file):

Previously, Alon-Ti wrote…

Maybe there should be a ReducedQM31 type that guarantees this?

Thanks. Made it safe by adding QM31Impl::mul_unreduced

This was referenced Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants