-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unreduced field arithmetic #116
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @andrewmilson and the rest of your teammates on Graphite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to suggestion once you appease scarb
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrewmilson and @shaharsamocha7)
stwo_cairo_verifier/src/fields/qm31.cairo
line 239 at r1 (raw file):
impl UnreducedQM31Mul of Mul<UnreducedQM31> { /// Returns `lhs * rhs`. Assumes input coordinates are in the range `[0, P)`.
Maybe there should be a ReducedQM31 type that guarantees this?
1eaef30
to
1ce253e
Compare
c901039
to
dc18c46
Compare
1ce253e
to
69267be
Compare
dc18c46
to
4f64214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @shaharsamocha7)
stwo_cairo_verifier/src/fields/qm31.cairo
line 239 at r1 (raw file):
Previously, Alon-Ti wrote…
Maybe there should be a ReducedQM31 type that guarantees this?
Thanks. Made it safe by adding QM31Impl::mul_unreduced
Used in downstream PR for computing FRI quotients.
This change is