Compute FRI quotients

[andrewmilson]

This change is 

[andrewmilson]

• Optimize decommiting last FRI layer using univariate FFT #133 : 2 dependent PRs (#152 , #153 )
• Add verifier #127
• Compute FRI quotients #118 👈
• Add CanonicCoset #117
• Add unreduced field arithmetic #116
• Refactor FRI implementation #115
• Refactor Coset with CirclePointIndex #114
• Add formatting to scarb.toml #113
• Update to latest Cairo version #112
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @andrewmilson and the rest of your teammates on Graphite

[Alon-Ti]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @andrewmilson and @shaharsamocha7)

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 196 at r1 (raw file):

    let mut queried_values_per_column_iter = queried_values_per_column.span().into_iter();

    loop {

Can't this work as an iteration on queried_values_per_column?

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 213 at r1 (raw file):

    let mut column_eval_offset = 0;

    // return Result::Err(VerificationError::InvalidStructure('queried vals'));

Remove

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 329 at r1 (raw file):

        for sample_batch in sample_batches
            .span() {
                // TODO(AlonH): This assertion will fail at a probability of 1 to 2^62.

Reassign TODO (I think Shahar wanted to add salt for this)

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 474 at r1 (raw file):

        sample_point: @CirclePoint<QM31>, sample_value: QM31, alpha: QM31
    ) -> ComplexConjugateLineCoeffs {
        // 12321564

?

[andrewmilson]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Alon-Ti and @shaharsamocha7)

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 196 at r1 (raw file):

Previously, Alon-Ti wrote…

Can't this work as an iteration on queried_values_per_column?

For and while loops don't allow breaking with a value

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 213 at r1 (raw file):

Previously, Alon-Ti wrote…

Remove

Whoops. Thanks

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 329 at r1 (raw file):

Previously, Alon-Ti wrote…

Reassign TODO (I think Shahar wanted to add salt for this)

Done.

---

stwo_cairo_verifier/src/pcs/quotients.cairo line 474 at r1 (raw file):

Previously, Alon-Ti wrote…

?

Removed. Ty

[Alon-Ti]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)