Add verifier

[andrewmilson]

This change is 

[andrewmilson]

• Add README to run verifier tests #152
• Optimize decommiting last FRI layer using univariate FFT #133
• Add verifier #127 👈 (View in Graphite)
• Add PCS verifier #173
• Add PoW check to channel #172
• Gen random circle point from channel #170
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[andrewmilson]

Reviewable status: 29 of 31 files reviewed, 3 unresolved discussions (waiting on @Alon-Ti and @shaharsamocha7)

---

stwo_cairo_verifier/src/utils.cairo line 218 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Then I don't think we need this code.
To check if a code has at least x trailing bits you only need one AND op

TODO maybe?

Funnily enough already had a TODO for it https://github.com/starkware-libs/stwo-cairo/pull/127/files#diff-ab0f3eb70a743b91de89fa4b965b564f1b175f2d254fd30703e7345eea5bf9caR141-R143.

Will implement it now though.

---

stwo_cairo_verifier/src/poly/circle.cairo line 104 at r1 (raw file):

Previously, shaharsamocha7 wrote…

cool, should we document that?

In the Rust code? As in make it clear the shift is to shift the coset to a canonic coset?

---

stwo_cairo_verifier/tests/verifier.cairo line 24 at r2 (raw file):

Previously, shaharsamocha7 wrote…

what's that?
We have a last layer bound?

Yeah I'm just saying it's a bug in Cairo to report. When you use this value at runtime log_last_layer_degree_bound is 4 even though it is set to 5. Yes, degree bound for last FRI layer

[shaharsamocha7]

Reviewable status: 29 of 31 files reviewed, 1 unresolved discussion (waiting on @Alon-Ti and @andrewmilson)

---

stwo_cairo_verifier/src/poly/circle.cairo line 104 at r1 (raw file):

Previously, andrewmilson (Andrew Milson) wrote…

In the Rust code? As in make it clear the shift is to shift the coset to a canonic coset?

I thought we should document here that for canonic cosets the shift is identity

[shaharsamocha7]

Reviewed 1 of 31 files at r1.
Reviewable status: 30 of 31 files reviewed, 2 unresolved discussions (waiting on @Alon-Ti and @andrewmilson)

---

stwo_cairo_verifier/src/verifier.cairo line 32 at r2 (raw file):

) -> Result<(), VerificationError> {
    let random_coeff = channel.draw_felt();

Please add a TODO to deal with preprocessed columns

[shaharsamocha7]

Reviewable status: 30 of 31 files reviewed, 4 unresolved discussions (waiting on @Alon-Ti and @andrewmilson)

---

a discussion (no related file):
We should split this pr

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 183 at r2 (raw file):

/// Returns all column log bounds deduped and sorted in ascending order.
#[inline]
fn get_column_log_bounds(

can this be replaced with a dict

Code quote:

fn get_column_log_bounds(

[andrewmilson]

Reviewable status: 24 of 31 files reviewed, 3 unresolved discussions (waiting on @Alon-Ti and @shaharsamocha7)

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 183 at r2 (raw file):

Previously, shaharsamocha7 wrote…

can this be replaced with a dict

Done.

---

stwo_cairo_verifier/src/poly/circle.cairo line 104 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I thought we should document here that for canonic cosets the shift is identity

Resolved offline.

---

stwo_cairo_verifier/Scarb.toml line 22 at r1 (raw file):

Previously, shaharsamocha7 wrote…

remove

Done.

[shaharsamocha7]

Reviewed 7 of 7 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)

[andrewmilson]

Reviewable status: 24 of 31 files reviewed, all discussions resolved (waiting on @Alon-Ti and @shaharsamocha7)

---

a discussion (no related file):

Previously, shaharsamocha7 wrote…

We should split this pr

Done.

• https://reviewable.io/reviews/starkware-libs/stwo-cairo/173
• https://reviewable.io/reviews/starkware-libs/stwo-cairo/172

[shaharsamocha7]

Reviewed 7 of 7 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Alon-Ti)