Add PCS verifier

[andrewmilson]

This change is 

[andrewmilson]

• Add README to run verifier tests #152
• Optimize decommiting last FRI layer using univariate FFT #133
• Add verifier #127
• Add PCS verifier #173 👈 (View in Graphite)
• Add PoW check to channel #172
• Gen random circle point from channel #170
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[shaharsamocha7]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @andrewmilson)

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 109 at r1 (raw file):

        if channel.trailing_zeros() < *self.config.pow_bits {
            return Result::Err(VerificationError::ProofOfWork);
        }

Can you change that to your new channel api?

Code quote:

        if channel.trailing_zeros() < *self.config.pow_bits {
            return Result::Err(VerificationError::ProofOfWork);
        }

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 275 at r1 (raw file):

    pub proof_of_work: u64,
    pub fri_proof: FriProof,
}

Can we move this struct declaration to top of file?
Also, can you explain the difference between sampled_values, queried_values? (I don't recall)

Code quote:

#[derive(Drop)]
pub struct CommitmentSchemeProof {
    pub sampled_values: TreeArray<ColumnArray<Array<QM31>>>,
    pub decommitments: TreeArray<MerkleDecommitment<PoseidonMerkleHasher>>,
    pub queried_values: TreeArray<ColumnArray<Array<M31>>>,
    pub proof_of_work: u64,
    pub fri_proof: FriProof,
}

[shaharsamocha7]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson)

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 61 at r1 (raw file):

    }

    // TODO(andrew): Introduce ColumnArray and TreeArray to make types less confusing.

You can remove this TODO, right?

Code quote:

// TODO(andrew): Introduce ColumnArray and TreeArray to make types less confusing.

[shaharsamocha7]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @andrewmilson)

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 109 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can you change that to your new channel api?

I see it is in the next pr

[andrewmilson]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 61 at r1 (raw file):

Previously, shaharsamocha7 wrote…

You can remove this TODO, right?

Done.

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 109 at r1 (raw file):

Previously, shaharsamocha7 wrote…

I see it is in the next pr

Done.

---

stwo_cairo_verifier/src/pcs/verifier.cairo line 275 at r1 (raw file):

Previously, shaharsamocha7 wrote…

Can we move this struct declaration to top of file?
Also, can you explain the difference between sampled_values, queried_values? (I don't recall)

Done. Added docs.

[shaharsamocha7]

Reviewed 4 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @andrewmilson)